feat(engine): erc20 gas token #662
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajbouw
added
C-enhancement
aleksuss
approved these changes
Jan 23, 2023
joshuajbouw
force-pushed
the
feat/erc20-gas-token
branch
from
d448ddd
to
8cb4265
Compare
joshuajbouw
force-pushed
the
feat/erc20-gas-token
branch
from
8cb4265
to
e704caf
Compare
aleksuss
reviewed
Jan 24, 2023
aleksuss
force-pushed
the
feat/erc20-gas-token
branch
2 times, most recently
from
7742836
to
2aada62
Compare
aleksuss
force-pushed
the
feat/erc20-gas-token
branch
from
2aada62
to
e8c34ef
Compare
aleksuss
reviewed
Feb 13, 2023
| /// This does not take gas into account. | ||
| pub fn can_transfer<I: IO>(io: &I, address: &Address, amount: Wei) -> bool { | ||
| let current_balance = get_balance(io, address); | ||
| amount >= current_balance |
There was a problem hiding this comment.
Probably should be less or equal?
Suggested change
| amount >= current_balance | |
| amount <= current_balance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a possible exciting feature unique to Aurora where you are able to pay in a gas token other than the base currency, in our case ETH. AURORA and others can then be used instead to pay for gas costs.
Performance / NEAR gas cost considerations
WIP
Testing
WIP
How should this be reviewed
WIP
Additional information
WIP