Skip to content

Feat(engine): Relayer payment#215

Merged
joshuajbouw merged 5 commits into
developfrom
relayer-payment
Aug 6, 2021
Merged

Feat(engine): Relayer payment#215
joshuajbouw merged 5 commits into
developfrom
relayer-payment

Conversation

@birchmd
Copy link
Copy Markdown
Member

@birchmd birchmd commented Aug 4, 2021

Someday we will require gas prices to be non-zero in order to cover the cost of running transactions on NEAR. This PR adds functionality to charge the transaction signer's address according to the gas limit and price, then pay the relayer's address based on the used gas, refunding the rest to the transaction signer.

Note: it is intentional that this only impacts the submit function because call is near-native in the sense that the NEAR transaction must have been signed by an access key for the corresponding account, therefore the caller is covering their own NEAR costs.

Copy link
Copy Markdown
Contributor

@sept-en sept-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments but they are quite minor.
Anyway LGTM, thanks for adding this!

Comment thread src/engine.rs
Comment thread src/engine.rs
Comment thread src/engine.rs Outdated
Comment thread src/engine.rs Outdated
Comment thread src/engine.rs Outdated
Comment thread src/engine.rs Outdated
Comment thread src/engine.rs Outdated
Comment thread src/engine.rs
Comment thread src/lib.rs Outdated
@joshuajbouw joshuajbouw merged commit bfcde0c into develop Aug 6, 2021
@joshuajbouw joshuajbouw deleted the relayer-payment branch August 6, 2021 10:45
artob added a commit that referenced this pull request Aug 14, 2021
* ERC-20: forbid using invalid NEP141 AccountID for mapping (#179)
* Timestamp should be in milliseconds for Ethereum compatibility (#208)
* feat(engine): Blockhash definition (#213)
* Update etc/state-migration-test/Cargo.lock (#211)
* Include cost of access list in intrinsic gas (#219)
* Bump tar from 4.4.13 to 4.4.15 in /etc/eth-contracts (#217)
* Feat(engine): Relayer payment (#215)
* Scheduled lint is supposed to run nightly clippy (#214)
* Return actual status of a transaction (#218)
* Added parser for Integer types (#183)
* Update to latest nightly (#221)
* Fix(engine): do not panic when user has insufficient balance to cover gas (#223)
* Update lock files (#224)
* Method to fix balance of aurora account on testnet (#225)
* Use math api host functions on mainnet (#228)
* NEP-141 compliance correctness (#202)
* Adapt workflows to dockerized runners (#231)
* Move block height to the end of hashed data. (#233)
* Ensure solidity artifacts are always recompiled (#234)
* Prevent test binary from deploying (#237)
* Add removal of eth-contracts to `make clean`
* Remove deploy_code feature gate

Co-authored-by: Dmitry Strokov <dmitry@aurora.dev>
Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Co-authored-by: Kirill <kirill@aurora.dev>
Co-authored-by: Michael Birch <michael@aurora.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category: New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants