NEP-141 compliance correctness#202
Merged
Merged
Conversation
8 tasks
joshuajbouw
approved these changes
Jul 28, 2021
birchmd
requested changes
Jul 28, 2021
Member
birchmd
left a comment
birchmd
left a comment
There was a problem hiding this comment.
Where is the fix for ft_balance_of?
Member
Author
It was fixed on |
birchmd
reviewed
Jul 28, 2021
birchmd
reviewed
Jul 28, 2021
birchmd
reviewed
Jul 28, 2021
Member
Author
|
NB: for discussion
|
birchmd
reviewed
Jul 28, 2021
joshuajbouw
suggested changes
Aug 2, 2021
Contributor
joshuajbouw
left a comment
joshuajbouw
left a comment
There was a problem hiding this comment.
As per comments in Slack, do the following to get information for a constant:
- Please check with NEAR what that JSON file is supposed to be like. It doesn't explain exactly what it should be in the standard.
- Double check our symbol with Alex or Arto
- SVG encode the aurora icon, get from Matt
- Calculate reference hash of the JSON file
- Give JSON file to Matt to upload to our website
joshuajbouw
approved these changes
Aug 9, 2021
birchmd
requested changes
Aug 9, 2021
…JsonValue for serialization; include icon in default value; serialize reference_hash as base64; add sanity test
birchmd
approved these changes
Aug 11, 2021
joshuajbouw
approved these changes
Aug 11, 2021
Contributor
|
Just need conflicts sorted and good to go. |
Member
Resolved in 2cfda54 |
artob
added a commit
that referenced
this pull request
Aug 14, 2021
* ERC-20: forbid using invalid NEP141 AccountID for mapping (#179) * Timestamp should be in milliseconds for Ethereum compatibility (#208) * feat(engine): Blockhash definition (#213) * Update etc/state-migration-test/Cargo.lock (#211) * Include cost of access list in intrinsic gas (#219) * Bump tar from 4.4.13 to 4.4.15 in /etc/eth-contracts (#217) * Feat(engine): Relayer payment (#215) * Scheduled lint is supposed to run nightly clippy (#214) * Return actual status of a transaction (#218) * Added parser for Integer types (#183) * Update to latest nightly (#221) * Fix(engine): do not panic when user has insufficient balance to cover gas (#223) * Update lock files (#224) * Method to fix balance of aurora account on testnet (#225) * Use math api host functions on mainnet (#228) * NEP-141 compliance correctness (#202) * Adapt workflows to dockerized runners (#231) * Move block height to the end of hashed data. (#233) * Ensure solidity artifacts are always recompiled (#234) * Prevent test binary from deploying (#237) * Add removal of eth-contracts to `make clean` * Remove deploy_code feature gate Co-authored-by: Dmitry Strokov <dmitry@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #191
Fixed:
storage_depositAdded:
ft_metadataget_metadata