Repository navigation
chore: refresh benchmarks for v1.21.0 - #890
Conversation
📝 WalkthroughWalkthroughBenchmark results in ChangesBenchmark Data and README Refresh
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryThis PR refreshes
Confidence Score: 3/5The README ratios are arithmetically correct, but the warm-install benchmark environment shows signs of interference — npm's stddev spiked 28x and aube's warm-install time nearly tripled. Landing these numbers as the canonical benchmark baseline without a re-run carries some risk of publishing misleading perf claims. aube's own benchmark jumped +188% in the warm-cache scenario, and npm's stddev explosion in the same scenario strongly suggests the benchmark machine was under load. If the environment was noisy, the 308ms→886ms aube result may not reflect actual 1.21.0 performance, which would make the published ratios inaccurate. benchmarks/results.json — the gvs-warm scenario warrants a targeted re-run before these numbers are treated as canonical. Important Files Changed
Reviews (1): Last reviewed commit: "chore: refresh benchmarks" | Re-trigger Greptile |
| "npm": 7136, | ||
| "yarn": 7708 | ||
| }, | ||
| "stats": { | ||
| "aube": { | ||
| "text": "0.308s ± 0.077s", | ||
| "mean": 0.30761542092000005, | ||
| "stddev": 0.07720214241262749, | ||
| "min": 0.24460349472, | ||
| "max": 0.43811340672000004 | ||
| "text": "0.886s ± 0.260s", | ||
| "mean": 0.8857092395799999, | ||
| "stddev": 0.2603188798119799, | ||
| "min": 0.41187857048000004, | ||
| "max": 1.13239212248 | ||
| }, | ||
| "bun": { | ||
| "text": "1.889s ± 0.326s", | ||
| "mean": 1.88935886912, | ||
| "stddev": 0.3258903880951513, | ||
| "min": 1.5542772249199999, | ||
| "max": 2.31304034192 | ||
| "text": "1.813s ± 0.395s", |
There was a problem hiding this comment.
npm warm-install stddev spiked 28x — possible noisy environment
npm's gvs-warm stddev went from 0.041s to 1.138s (a 28x increase), with a min/max spread of 6.36s–8.82s vs the previous run's tight 7.02s–7.12s range. That level of variance strongly suggests OS or network interference during this scenario's run. A noisy environment can silently drag other tools' numbers in either direction too. Worth re-running the warm-cache scenario in isolation to confirm the aube 308ms→886ms jump is real and not an artifact of a loaded machine.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
🤖 Refreshed benchmarks
benchmarks/results.jsonwas pinned to aube1.19.0; the workspace is now1.21.0. Re-ranmise run bench:bumpon the hermetic Verdaccio registry (500mbit / 50ms per the mise task) and regeneratedbenchmarks/results.jsonplus the READMEBENCH_RATIOSblock. The benchmark matrix pins aube's GVS mode vianpm_config_enable_global_virtual_store=true|false(the auto-synthesized env alias for theenableGlobalVirtualStoresetting), so GitHub Actions' inheritedCI=trueenvironment does not change whether aube runs with GVS enabled or disabled.Benchmark changes
Versions:
Public ratios: warm installs vs Bun 6x -> 2x; warm installs vs pnpm 8x -> 3x; repeat test vs Bun 5x -> 5x; repeat test vs pnpm 34x -> 30x.
Review the numbers before merging — if anything looks wildly off vs. the previous release, investigate before landing. Hermetic proxy jitter or an npmjs uplink hiccup can occasionally skew results.
Once merged to main, the updated bench results flow into the next
release-plz-prrun automatically.Generated by the
bench-refreshworkflow.Note
Low Risk
Documentation and benchmark artifact updates only; no runtime or application code changes.
Overview
Refreshes published benchmark data for aube 1.21.0 (from 1.19.0) by updating
benchmarks/results.jsonand the auto-generatedBENCH_RATIOSblock inREADME.md.README marketing ratios are revised to match the new numbers: warm install vs pnpm 8x → 3x, vs Bun 6x → 2x, and repeat test vs pnpm 34x → 30x (vs Bun stays 5x).
The JSON run records new timings and stats for all three scenarios (warm/cold fresh install, install+test) across aube, bun, deno, pnpm, npm, and yarn—notably aube warm install rises from ~308ms to ~886ms while cold install and repeat-test numbers stay in a similar ballpark.
Reviewed by Cursor Bugbot for commit 63eae44. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit