Repository navigation
chore: refresh benchmarks for v1.22.0 - #907
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBenchmark measurements in ChangesBenchmark Refresh
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR refreshes the benchmark data for the aube 1.22.0 release, bumping pnpm to 11.7.0 and yarn to 4.17.0, and regenerates the README
Confidence Score: 4/5Safe to merge after confirming the aube cold-cache regression is expected for 1.22.0 and the pnpm warm-install ratio wording is acceptable. Both findings are non-blocking: one is a wording accuracy concern in the README (2.63x described as "about 3x"), the other is a +16% cold-cache regression that the PR description itself flags as needing review but that appears stable rather than jitter. benchmarks/results.json — the cold-cache row for aube and the warm-cache row for yarn both show notable regressions that deserve a second look before merging. Important Files Changed
Reviews (1): Last reviewed commit: "chore: refresh benchmarks" | Re-trigger Greptile |
|
|
||
| <!-- BENCH_RATIOS:START --> | ||
| **[Fast installs](https://aube.jdx.dev/benchmarks).** Warm installs are about 3x faster than pnpm and about 2x faster than Bun in the current benchmarks. Repeat test commands run up to 30x faster than pnpm and up to 5x faster than Bun. | ||
| **[Fast installs](https://aube.jdx.dev/benchmarks).** Warm installs are about 3x faster than pnpm and ~1.8x faster than Bun in the current benchmarks. Repeat test commands run up to 42x faster than pnpm and up to 8x faster than Bun. |
There was a problem hiding this comment.
Warm-install pnpm ratio is now 2.63x, not ~3x
The updated JSON gives aube=787ms vs pnpm=2074ms, a ratio of 2074/787 ≈ 2.63x. The previous run was 2512/886 ≈ 2.84x, which made rounding to "about 3x" defensible. At 2.63x the claim has slipped noticeably; "about 2.6x" or "nearly 3x" would be more accurate and harder to dispute in benchmarks discussions.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| "aube": 6821, | ||
| "bun": 5429, | ||
| "deno": 7964, | ||
| "pnpm": 11206, | ||
| "npm": 9054, | ||
| "yarn": 12186 | ||
| }, |
There was a problem hiding this comment.
aube cold-cache regression worth investigating before merge
The PR description explicitly asks reviewers to flag anything that "looks wildly off." aube's cold-cache install went from 5860ms → 6821ms (+16%), while every other manager either improved (pnpm: -13%) or stayed flat. This is the only scenario where aube now trails Bun (6821ms vs 5429ms). Worth confirming this is expected for 1.22.0 rather than hermetic-proxy jitter — given the tight stddev (±0.236s) the result appears stable, which makes the regression more likely real.
🤖 Refreshed benchmarks
benchmarks/results.jsonwas pinned to aube1.21.0; the workspace is now1.22.0. Re-ranmise run bench:bumpon the hermetic Verdaccio registry (500mbit / 50ms per the mise task) and regeneratedbenchmarks/results.jsonplus the READMEBENCH_RATIOSblock. The benchmark matrix pins aube's GVS mode vianpm_config_enable_global_virtual_store=true|false(the auto-synthesized env alias for theenableGlobalVirtualStoresetting), so GitHub Actions' inheritedCI=trueenvironment does not change whether aube runs with GVS enabled or disabled.Benchmark changes
Versions:
Public ratios: warm installs vs Bun 2x -> 1.8x; warm installs vs pnpm 3x -> 3x; repeat test vs Bun 5x -> 8x; repeat test vs pnpm 30x -> 42x.
Review the numbers before merging — if anything looks wildly off vs. the previous release, investigate before landing. Hermetic proxy jitter or an npmjs uplink hiccup can occasionally skew results.
Once merged to main, the updated bench results flow into the next
release-plz-prrun automatically.Generated by the
bench-refreshworkflow.Note
Low Risk
Documentation and benchmark artifact updates only; no runtime or package-manager logic changes.
Overview
Re-runs the hermetic benchmark suite (
mise run bench:bump) and pinsbenchmarks/results.jsonto the current workspace release (aube 1.22.0), along with bumped comparator versions (pnpm 11.7.0, yarn 4.17.0). Timings and mean/stddev stats are replaced for warm/cold fresh installs and the repeat install && test scenario.The
README.mdBENCH_RATIOSblock is regenerated from the new JSON: warm vs Bun is now ~1.8x (was ~2x), repeat test vs pnpm up to 42x (was 30x) and vs Bun up to 8x (was 5x); warm vs pnpm stays ~3x.Reviewed by Cursor Bugbot for commit 3c037b0. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Documentation
Chores