[pull] master from gatsbyjs:master #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ents (#26861) * add generic type to useScrollRestoration hook this is required to match the type of `useRef` which requires the target element type to be specified. The hook can be used like the following: ```typescript const MyComponent: React.FunctionComponent = () => { const scrollRestorationProps = useScrollRestoration<HTMLDivElement>(`some-key`) return ( <div {...scrollRestorationProps} style={{ overflow: `auto` }} > Test </div> ) } ``` Fixes: #26458 * add tests for useScrollRestoration hook * fix useScrollResotration to update position on location change Previously, the scroll position was only updated when the using component was re-rendered. This did not work when the hook is used in a wrapping Layout component, becaus its persitent over location changes. Adding the location key to useEffect will cause the scroll position is updated every time the key changes. * lint/ts fixes Co-authored-by: Vladimir Razuvaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )