feat(gatsby-source-wordpress): use docker for tests #30938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
added
topic: source-wordpress
sslotsky
reviewed
Apr 23, 2021
integration-tests/gatsby-source-wordpress/__tests__/__snapshots__/index.js.snap
Show resolved
Hide resolved
sslotsky
reviewed
Apr 23, 2021
pieh
reviewed
Apr 26, 2021
pieh
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ship
gatsby-source-wordpresswe previously removed docker from our tests and used a live WP url. This was done because in switching from Github actions to CircleCI, we couldn't properly expose dockers WP url to Gatsby. It turns out the reason was that we were using the custom node executor that all the other Gatsby integration tests are using. Custom executors run in a docker container and don't allow for networking with nested docker containers (due to a security hole that would open in circleCI). Switching to the machine executor runs the WP tests in a linux VM which allows for proper networking between Gatsby and our docker containers.That fix was simple but our test setup turned out to need a bunch of other tweaks to get things running again properly, hence the long list of commits here.