Closed
Conversation
🦋 Changeset detectedLatest commit: 0768f8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Nice work!! Does this enable multiple entry points? Not sure how common this is in the wild, but our app uses multiple entry points to build bundles for independent apps (website, chrome extension, embed etc) within a monorepo. Being able to only include styles used for a particular entry point would be great! |
Contributor
Author
|
Hi! Yeah exactly, need to investigate what happens and probably tweak it 🙂 |
9 tasks
Contributor
Author
|
Closing, this can be used as a reference when picking it up later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #722
Seems to work, need to think about edge cases. As well as what happens with multiple entry points. This might also closes #669 as we remove the need for placing everything into a single style sheet via cache groups.
@jantimon how's this look?
Changes
TODO