Generate macro code coverage report for ASPEC::Methods.assert_compiles usages#642
Merged
Blacksmoke16 merged 1 commit intomasterfrom Dec 29, 2025
Merged
Generate macro code coverage report for ASPEC::Methods.assert_compiles usages#642Blacksmoke16 merged 1 commit intomasterfrom
ASPEC::Methods.assert_compiles usages#642Blacksmoke16 merged 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
📢 Thoughts on this report? Let us know! |
Blacksmoke16
added a commit
to athena-framework/spec
that referenced
this pull request
Dec 29, 2025
…es` usages (athena-framework/athena#642) ## Context athena-framework/athena#551 made it so that only `assert_compile_time_error` generates a macro code coverage report. `assert_compiles` should also as it can be used to test success paths in isolation, which otherwise would have some lines/code paths go unreported. ## Changelog - Generate macro code coverage report for `ASPEC::Methods.assert_compiles` usages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
#551 made it so that only
assert_compile_time_errorgenerates a macro code coverage report.assert_compilesshould also as it can be used to test success paths in isolation, which otherwise would have some lines/code paths go unreported.Changelog
ASPEC::Methods.assert_compilesusagesBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title