Merged
Conversation
Blacksmoke16
added
component:framework
component:console
component:dependency-injection
component:event-dispatcher
component:spec
component:routing
kind:enhancement
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Thoughts on this report? Let us know! |
Doc updates
PallasAthenaie
pushed a commit
to athena-framework/console
that referenced
this pull request
Jul 27, 2025
PallasAthenaie
pushed a commit
to athena-framework/dependency-injection
that referenced
this pull request
Jul 27, 2025
PallasAthenaie
pushed a commit
to athena-framework/event-dispatcher
that referenced
this pull request
Jul 27, 2025
PallasAthenaie
pushed a commit
to athena-framework/framework
that referenced
this pull request
Jul 27, 2025
PallasAthenaie
pushed a commit
to athena-framework/routing
that referenced
this pull request
Jul 27, 2025
PallasAthenaie
pushed a commit
to athena-framework/spec
that referenced
this pull request
Jul 27, 2025
Blacksmoke16
added a commit
to athena-framework/dependency-injection
that referenced
this pull request
Dec 26, 2025
Blacksmoke16
added a commit
that referenced
this pull request
Dec 29, 2025
…es` usages (#642) ## Context #551 made it so that only `assert_compile_time_error` generates a macro code coverage report. `assert_compiles` should also as it can be used to test success paths in isolation, which otherwise would have some lines/code paths go unreported. ## Changelog - Generate macro code coverage report for `ASPEC::Methods.assert_compiles` usages
Blacksmoke16
added a commit
to athena-framework/spec
that referenced
this pull request
Dec 29, 2025
…es` usages (athena-framework/athena#642) ## Context athena-framework/athena#551 made it so that only `assert_compile_time_error` generates a macro code coverage report. `assert_compiles` should also as it can be used to test success paths in isolation, which otherwise would have some lines/code paths go unreported. ## Changelog - Generate macro code coverage report for `ASPEC::Methods.assert_compiles` usages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Depends on and integrates crystal-lang/crystal#15738 into the
speccomponent,test.shscript, and CI flow. A macro level code coverage report will now be generated for each component and each compile time failure test path.Also does a bit of a pass on
speccomponent to make it a bit more clear.Changelog
codegenparameter fromASPEC::Methods.assert_errorandASPEC::Methods.assert_successASPEC::Methods.assert_errorin favor ofASPEC::Methods.assert_compile_time_errorandASPEC::Methods.assert_runtime_errorASPEC::Methods.assert_successin favor ofASPEC::Methods.assert_compilesandASPEC::Methods.assert_executesBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title