Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orijtech/structslop linter fails to build using Go 1.23rc1 #1585

Closed
atc0005 opened this issue Jun 24, 2024 · 0 comments · Fixed by #1586
Closed

orijtech/structslop linter fails to build using Go 1.23rc1 #1585

atc0005 opened this issue Jun 24, 2024 · 0 comments · Fixed by #1586
Assignees
@atc0005
Labels
bug Something isn't working dependencies linting unstable
Milestone
v0.21.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 24, 2024

Overview

The current version of the upstream project does not support Go 1.23 due to a dependency on the internal runtime.roundupsize function which is no longer exposed via //go:linkname.

References
@atc0005 atc0005 added bug Something isn't working dependencies unstable labels Jun 24, 2024
@atc0005 atc0005 added this to the Next Release milestone Jun 24, 2024
@atc0005 atc0005 self-assigned this Jun 24, 2024
@atc0005 atc0005 changed the title Remove orijtech/structslop from unstable image due to incompatibility with Go 1.23 orijtech/structslop linter fails to build using Go 1.23rc1 Jun 24, 2024
atc0005 added a commit that referenced this issue Jun 24, 2024
@atc0005
Remove orijtech/structslop from unstable image
740aff5 
The latest upstream version of this linter fails to build
using Go 1.23rc1. The linter is retained in the oldstable
and stable images for now as the forked/patched version
continues to build using Go 1.21 and Go 1.22.

refs GH-1585
refs GH-1583
@atc0005 atc0005 mentioned this issue Jun 24, 2024
Merged
atc0005 added a commit that referenced this issue Jun 24, 2024
@atc0005
Remove orijtech/structslop from unstable image
304520f 
The latest upstream version of this linter fails to build
using Go 1.23rc1. The linter is retained in the oldstable
and stable images for now as the forked/patched version
continues to build using Go 1.21 and Go 1.22.

refs GH-1585
refs GH-1583
atc0005 added a commit that referenced this issue Jun 24, 2024
@atc0005
Cleanup forked linter version details
65c1021 
- update README to explicitly list commits for forked linter
  repos
- update ENV var values for `builder` and `final` images to
  specify forked linter repo commit instead of latest upstream
  version tag (which doesn't match the custom build)

refs GH-1585
refs GH-1328
refs GH-1363
refs GH-1400
@atc0005 atc0005 mentioned this issue Jun 24, 2024
Merged
@atc0005 atc0005 mentioned this issue Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working dependencies linting unstable
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging a pull request may close this issue.

Remove orijtech/structslop from unstable image atc0005/go-ci
1 participant
@atc0005