Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch orijtech linters install source for stable images #1400

Closed
atc0005 opened this issue Feb 16, 2024 · 0 comments · Fixed by #1401
Closed

Switch orijtech linters install source for stable images #1400

atc0005 opened this issue Feb 16, 2024 · 0 comments · Fixed by #1401
Assignees
@atc0005
Labels
bug Something isn't working dependencies linting stable
Milestone
v0.15.2

Comments

@atc0005
Copy link
Owner

atc0005 commented Feb 16, 2024

Overview

Now that the stable images have switched from Go 1.21 series images to Go 1.22 they will need the same set of hotfixes applied in order to work with Go 1.22.

References
@atc0005 atc0005 self-assigned this Feb 16, 2024
@atc0005 atc0005 added this to the Next Release milestone Feb 16, 2024
atc0005 added a commit to atc0005/shared-project-resources that referenced this issue Feb 16, 2024
@atc0005
Temporarily disable optional linters in stable img
26cec13 
Skip running optional linters set in the stable image as a
workaround for the upstream version of those linters being
incompatible with Go 1.22.

Once the stable image(s) have been rebuilt with hotfixes to
workaround that incompatibility we can re-enable them.

refs atc0005/go-ci#1400
atc0005 added a commit to atc0005/shared-project-resources that referenced this issue Feb 16, 2024
@atc0005
Temporarily disable optional linters in stable img
e0c2e14 
Skip running optional linters set in the stable image as a
workaround for the upstream version of those linters being
incompatible with Go 1.22.

Once the stable image(s) have been rebuilt with hotfixes to
workaround that incompatibility we can re-enable them.

refs atc0005/go-ci#1400
@atc0005 atc0005 mentioned this issue Feb 16, 2024
Merged
atc0005 added a commit to atc0005/shared-project-resources that referenced this issue Feb 16, 2024
@atc0005
Temporarily disable optional linters in stable img
6281c76 
Skip running optional linters set in the stable image as a
workaround for the upstream version of those linters being
incompatible with Go 1.22.

Once the stable image(s) have been rebuilt with hotfixes to
workaround that incompatibility we can re-enable them.

refs atc0005/go-ci#1400
atc0005 added a commit that referenced this issue Feb 16, 2024
@atc0005
Use builder/final pattern for stable Dockerfile
f06e4d9 
Mirror the setup used by the unstable combined Dockerfile.

This allows us to more easily generate custom builds (with updated
dependencies) of orijtech linters until the upstream versions
are patched.

refs GH-1400
@atc0005 atc0005 mentioned this issue Feb 16, 2024
Merged
atc0005 added a commit to atc0005/shared-project-resources that referenced this issue Feb 16, 2024
@atc0005
Revert "Temporarily disable optional linters in stable img"
38af515 
This reverts commit 6281c76.

refs atc0005/go-ci#1400
refs #177
@atc0005 atc0005 mentioned this issue Feb 16, 2024
Merged
atc0005 added a commit that referenced this issue Jun 24, 2024
@atc0005
Cleanup forked linter version details
65c1021 
- update README to explicitly list commits for forked linter
  repos
- update ENV var values for `builder` and `final` images to
  specify forked linter repo commit instead of latest upstream
  version tag (which doesn't match the custom build)

refs GH-1585
refs GH-1328
refs GH-1363
refs GH-1400
@atc0005 atc0005 mentioned this issue Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working dependencies linting stable
Projects
None yet
Milestone
v0.15.2
Development

Successfully merging a pull request may close this issue.

Use builder/final pattern for stable Dockerfile atc0005/go-ci
1 participant
@atc0005