chore: update meetings.json and newsrooom_videos.json #4528
Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughA new Governance Board Meeting entry (November 3rd, 2025) was added to config/meetings.json, and a corresponding video entry was inserted into config/newsroom_videos.json while removing an older Governance Board Meeting video entry (September 29th, 2025). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4528 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 780 780
Branches 144 144
=========================================
Hits 780 780 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/newsroom_videos.json (1)
2-7: Description format inconsistency: consider narrative text or standardization.The new video entry's description field contains only a GitHub URL with trailing period ("asyncapi/community#2116."), which differs from other entries in the file that provide narrative summaries (e.g., "Join us this year for another edition…" or "Join us on the 14th of October…"). If issue-linked videos intentionally use URL-only descriptions, this is acceptable; however, standardizing the format would improve consistency. The trailing period also differs from the URL-only format in the meetings.json reference (which has no trailing period).
If narrative descriptions are preferred, consider updating the description to match the pattern used elsewhere. If URL-only descriptions are intentional for issue-linked entries, consider removing the trailing period for consistency:
- "description": "https://github.com/asyncapi/community/issues/2116.", + "description": "https://github.com/asyncapi/community/issues/2116"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: asyncapi-bot
Repo: asyncapi/website PR: 0
File: :0-0
Timestamp: 2025-02-18T12:07:42.211Z
Learning: The following PR commands are supported in the asyncapi/website repository:
- `/please-take-a-look` or `/ptal`: Requests attention from reviewers who haven't reviewed the PR
- `/ready-to-merge` or `/rtm`: Triggers automerge when all conditions are met
- `/do-not-merge` or `/dnm`: Blocks automerge even if all conditions are met
- `/autoupdate` or `/au`: Adds autoupdate label to keep PR in sync with target branch
- `/update` or `/u`: One-time update of PR with latest changes from target branch
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Test NodeJS PR - windows-latest
🔇 Additional comments (1)
config/meetings.json (1)
114-120: Valid new meeting entry; data structure and cross-file consistency confirmed.The new Governance Board Meeting entry is well-formed with all required fields properly populated. The entry correctly references GitHub issue #2116, which aligns with the corresponding video entry in config/newsroom_videos.json. Date format is valid ISO 8601, and the Google Calendar link structure matches existing entries.
asyncapi-bot
deleted the
update-meetings/9611f420725a7f0d08a46de4a45de32b0753659b
branch
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4528--asyncapi-website.netlify.app/ |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit