-
-
Notifications
You must be signed in to change notification settings - Fork 991
chore: update meetings.json and newsrooom_videos.json #4419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4419
Conversation
WalkthroughAdded two Governance Board Meeting entries to config/meetings.json. Updated config/newsroom_videos.json by inserting a new video at the top and removing one older video. No schema or structural changes; existing entries remain otherwise unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4419 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4419--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/newsroom_videos.json (1)
2-7: Minor polish — remove trailing period from top entry description
- Verified: JSON valid; no duplicate videoIds. Top entry (config/newsroom_videos.json, index 0) description ends with a trailing period — remove the final '.' from "asyncapi/community#2069." to avoid autolink issues.
- Optional: normalize spacing before commas in titles across the file for consistency (some entries contain a space before commas).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - windows-latest
🔇 Additional comments (1)
config/meetings.json (1)
134-148: Approve — entries valid; manual calLink check required
- meetings.json is valid JSON and contains no duplicate Governance Board dates.
- New entries present: 2025-09-02T16:00:00.000Z → issue #2073; 2025-09-29T16:00:00.000Z → issue #2074.
- File order is not strictly chronological (09-15 appears before 09-02); frontend sorts events at runtime in utils/staticHelpers.ts (meetingsWithDates.sort((a:any,b:any)=>a.date - b.date)), so no change needed unless a consumer relies on in-file ordering.
- CalLink eid decode returned binary and remote validation is inconclusive from this environment — open the Google Calendar links to confirm they resolve to the intended events/times (16:00Z) and map to issues #2073/#2074.
* docs(community): update latest community documentation (#4407) * chore: update meetings.json and newsrooom_videos.json (#4410) * chore: update meetings.json and newsrooom_videos.json (#4405) * chore: update meetings.json, newsrooom_videos.json and dashboard.json * Update meetings.json --------- Co-authored-by: asyncapi-bot <[email protected]> Co-authored-by: Eve <[email protected]> Co-authored-by: Sambhav Gupta <[email protected]> * chore: update meetings.json and newsrooom_videos.json (#4411) * fix: #4065 Made Case Studies page table section mobile responsive (#4403) * fixes #4065. Made Case Studie page mobile responsive * fixes #4065. Made Case Studie page mobile responsive * fix: #4381 --------- Co-authored-by: Sambhav Gupta <[email protected]> * chore(deps): bump axios from 1.8.2 to 1.12.1 (#4413) * chore(deps): bump @babel/runtime and next-language-detector (#4414) * chore: update tools.json (#4417) * chore: update meetings.json and newsrooom_videos.json (#4419) * ci: update of files from global .github repo (#4418) * fix: broken AsyncAPI contributing guidelines link (#4395) (#4398) Co-authored-by: SanidhyaMadheshia <[email protected]> Co-authored-by: Sambhav Gupta <[email protected]> Co-authored-by: V Thulisile Sibanda <[email protected]> --------- Co-authored-by: Chan <[email protected]> Co-authored-by: asyncapi-bot <[email protected]> Co-authored-by: Eve <[email protected]> Co-authored-by: namanjain24-sudo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SanidhyaMadheshia <[email protected]> Co-authored-by: SanidhyaMadheshia <[email protected]> Co-authored-by: V Thulisile Sibanda <[email protected]>
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit