-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: update meetings.json and newsrooom_videos.json #4325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4325
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughUpdated config/newsroom_videos.json by prepending a new Aug 12, 2025 AsyncAPI Community WG Meeting entry and removing the previous last entry (July 1, 2025). The array size reduced from 6 to 5; other existing entries remain unchanged. JSON structure and field names are unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4325 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4325--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
config/newsroom_videos.json (2)
4-4: Remove extra space before comma in title for punctuation correctness.Normalize to "Meeting, Tuesday ..." (there’s already at least one entry following this style in the same file).
- "title": "AsyncAPI Community WG Meeting , Tuesday August 12th 2025", + "title": "AsyncAPI Community WG Meeting, Tuesday August 12th 2025",Follow-up: consider sweeping the file to remove the stray space before commas in other titles for consistency.
5-5: Avoid trailing period after URL in description.Trailing punctuation can break auto-linking in some renderers.
- "description": "https://github.com/asyncapi/community/issues/2014.", + "description": "https://github.com/asyncapi/community/issues/2014",
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/newsroom_videos.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - macos-13
- GitHub Check: Test NodeJS PR - windows-latest
🔇 Additional comments (2)
config/newsroom_videos.json (2)
3-6: Thumbnail ID matches videoId. LGTM.image_url and videoId are consistent (ncOFU__8hLM). JSON structure is correct.
2-7: External references verified
All external links—the YouTube video (ID: ncOFU__8hLM via oEmbed), its thumbnail URL, and GitHub issue #2014—respond with HTTP 200 and valid metadata. No dead links detected.
| [ | ||
| { | ||
| "image_url": "https://i.ytimg.com/vi/ncOFU__8hLM/hqdefault.jpg", | ||
| "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo in month name in title.
"Auguest" should be "August".
- "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025",
+ "title": "AsyncAPI Community WG Meeting , Tuesday August 12th 2025",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "title": "AsyncAPI Community WG Meeting , Tuesday Auguest 12th 2025", | |
| "title": "AsyncAPI Community WG Meeting , Tuesday August 12th 2025", |
🤖 Prompt for AI Agents
In config/newsroom_videos.json around line 4, the title contains a typo
"Auguest" — change it to the correct spelling "August" so the title reads
"AsyncAPI Community WG Meeting , Tuesday August 12th 2025". Ensure you only
correct the month spelling and keep the rest of the string intact.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit