-
-
Notifications
You must be signed in to change notification settings - Fork 993
chore: update meetings.json and newsrooom_videos.json #4291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #4291
Conversation
WalkthroughThis update removes one previously scheduled AsyncAPI Community Working Group meeting from April 22, 2025, and adds two new meetings scheduled for August 7 and August 12, 2025, in the meetings configuration. It also updates the newsroom videos by adding three new video entries dated July 29, 2025, and removing three older entries from June 17, 2025. No code or exported entities were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4291 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 778 778
Branches 144 144
=========================================
Hits 778 778 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4291--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
config/meetings.json (1)
149-155: Confirm ordering & naming consistency for new meeting entryThe new Community WG meeting is appended after the 29 Jul entries, yet earlier rows are not strictly chronological (e.g., 29 May follows 03 Jun). If consumers rely on natural order, consider sorting the whole array (ASC or DESC) once per update to avoid accidental regressions.
Additionally, titles alternate between
• “AsyncAPI Community WG Meeting”
• “AsyncAPI Community Working Group Meeting”Unifying the wording will help future consumers filter or search reliably.
config/newsroom_videos.json (1)
4-11: Minor formatting inconsistency in titlesThere is an extra space before the comma (“Meeting , Tuesday”) that does not exist in the other titles (“Meeting, Tuesday”). For visual consistency across the carousel, trim the space:
- "title": "AsyncAPI Community WG Meeting , Tuesday July 29th 2025", + "title": "AsyncAPI Community WG Meeting, Tuesday July 29th 2025",Repeat for the second entry.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/meetings.json(1 hunks)config/newsroom_videos.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: asyncapi-bot
PR: asyncapi/website#0
File: :0-0
Timestamp: 2025-02-18T12:07:42.211Z
Learning: The following PR commands are supported in the asyncapi/website repository:
- `/please-take-a-look` or `/ptal`: Requests attention from reviewers who haven't reviewed the PR
- `/ready-to-merge` or `/rtm`: Triggers automerge when all conditions are met
- `/do-not-merge` or `/dnm`: Blocks automerge even if all conditions are met
- `/autoupdate` or `/au`: Adds autoupdate label to keep PR in sync with target branch
- `/update` or `/u`: One-time update of PR with latest changes from target branch
Learnt from: iambami
PR: asyncapi/website#4111
File: markdown/blog/community-spotlight-aayush.md:3-3
Timestamp: 2025-06-03T06:48:09.304Z
Learning: For AsyncAPI community spotlight blog posts, the frontmatter date should reflect the actual publication date, not the month being highlighted in the spotlight. For example, a "May Community Spotlight" can be published in June with a June date in the frontmatter.
Learnt from: akshatnema
PR: asyncapi/website#3265
File: tests/fixtures/toolsObjectData.js:51-52
Timestamp: 2024-10-09T17:35:36.557Z
Learning: When reviewing code in the 'asyncapi/website' repository, akshatnema prefers that I do not provide committable code suggestions.
Learnt from: anshgoyalevil
PR: asyncapi/website#3557
File: scripts/markdown/check-editlinks.js:58-59
Timestamp: 2025-01-08T15:15:00.759Z
Learning: In the AsyncAPI codebase, batch processing operations (like in the Dashboard script and check-editlinks.js) follow a sequential pattern using await in loops, which is the preferred approach for maintaining consistency across the codebase.
config/meetings.json (1)
Learnt from: iambami
PR: #4111
File: markdown/blog/community-spotlight-aayush.md:3-3
Timestamp: 2025-06-03T06:48:09.304Z
Learning: For AsyncAPI community spotlight blog posts, the frontmatter date should reflect the actual publication date, not the month being highlighted in the spotlight. For example, a "May Community Spotlight" can be published in June with a June date in the frontmatter.
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/newsroom_videos.json (1)
2-13: Confirm duplicate meeting entries in config/newsroom_videos.jsonI ran the provided script and found two entries pointing to the same Community WG meeting (GitHub issue #1988) but with different
videoIds:
- config/newsroom_videos.json
• title: “AsyncAPI Community WG Meeting, Tuesday July 29th 2025”
• description: “https://github.com/asyncapi/community/issues/1988.”
• videoIds:xD5smwg6az8,7vvdmDVZPX0Please confirm whether these are intentionally two separate recordings (e.g., full meeting vs. highlights).
- If they are distinct videos, consider adding a clarifying label (e.g., “Full Meeting” / “Highlights”) so users know the difference.
- Otherwise, remove the redundant entry to prevent UI clutter.
6967778 to
9394370
Compare
9394370 to
dd26692
Compare
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Updates