Skip to content

feat: add unit tests for newsroom-videos scripts #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 31, 2023
Merged

feat: add unit tests for newsroom-videos scripts #1988

merged 12 commits into from
Jul 31, 2023

Conversation

@reachaadrika
Copy link
Contributor

@reachaadrika reachaadrika commented Jul 24, 2023

Description

  • This PR has unit tests written for Nodejs scripts newsroom_videos and build_meetings .

Related issue(s)
fixes #1987

@netlify
Copy link

netlify bot commented Jul 24, 2023 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6fcd3da
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64c81bde2ce91700088623ad
😎 Deploy Preview https://deploy-preview-1988--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reachaadrika reachaadrika changed the title feat : adding tests for scripts folder - newsroom_videos and build-meetings feat: add tests for scripts folder - newsroom_videos and build-meetings Jul 24, 2023
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 36
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1988--asyncapi-website.netlify.app/

@reachaadrika reachaadrika changed the title feat: add tests for scripts folder - newsroom_videos and build-meetings feat: add unit tests for meetings and newsroom-videos pages Jul 24, 2023
@akshatnema akshatnema added the gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code label Jul 25, 2023
@reachaadrika reachaadrika changed the title feat: add unit tests for meetings and newsroom-videos pages feat: add unit tests for newsroom-videos scripts Jul 30, 2023
akshatnema
akshatnema requested changes Jul 30, 2023
View reviewed changes
@akshatnema
Copy link
Member

akshatnema commented Jul 31, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit c175f86 into asyncapi:master Jul 31, 2023
@derberg derberg mentioned this pull request Aug 9, 2023
Closed
@coderabbitai coderabbitai bot mentioned this pull request Jul 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshatnema akshatnema akshatnema approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@Mayaleeeee Mayaleeeee Awaiting requested review from Mayaleeeee Mayaleeeee is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees

No one assigned

Labels

gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code ready-to-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

write tests for scripts folder

3 participants

@reachaadrika @akshatnema @asyncapi-bot