Skip to content

Conversation

@derberg
Copy link
Member

@derberg derberg commented Mar 8, 2021

Description

The goal of this post is to make it easier to read asyncapi charter proposal

@netlify
Copy link

netlify bot commented Mar 8, 2021

Deploy preview for asyncapi-website processing.

Building with commit 49bbb03

https://app.netlify.com/sites/asyncapi-website/deploys/60464c1b74e3b7000825b0cd

@derberg derberg requested a review from fmvilas March 8, 2021 12:16
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 great stuff!

derberg and others added 2 commits March 8, 2021 15:45
Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good man 👏

Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
derberg and others added 2 commits March 8, 2021 17:05
Co-authored-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
@derberg
Copy link
Member Author

derberg commented Mar 8, 2021

@fmvilas thanks a lot for the detailed review mate, all changes applied.

@smoya thanks mate, there is one open questions only, and a bit different solution to your proposal

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! 💯 🚀

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 🚀

@derberg derberg merged commit b2aa94d into asyncapi:master Mar 8, 2021
@derberg derberg deleted the open-gov branch March 8, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants