Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add editor in next.js #997

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

Shurtu-gal
Copy link
Collaborator

Description

  • Add editor to the studio-next in next.js
  • Using code mirror instead of Monaco
  • Is a minimal editor with file state and local storage baked into it
  • Use esc + tab for the normal tab and just tab if you want in the editor.

Related issue(s)
Fixes #684

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 2b2ff8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 8f3bd66
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/65f0cdbe67d4820008ab96c9
😎 Deploy Preview https://deploy-preview-997--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 8f3bd66
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/65f0cdbea7744f00087e6ed7
😎 Deploy Preview https://deploy-preview-997--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 2b2ff8d
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/65f177a7e163d50008b528b7
😎 Deploy Preview https://deploy-preview-997--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 2b2ff8d
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/65f177a75ff2a30008b0fc14
😎 Deploy Preview https://deploy-preview-997--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Amzani
Amzani previously approved these changes Mar 13, 2024
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! @Shurtu-gal 🚀
I think we can merge it, however, it doesn't completely fix #684 as we expect to have a minimal working app with menu + preview documentation.
We will need this as well #703

@Amzani
Copy link
Collaborator

Amzani commented Mar 13, 2024

@Shurtu-gal we should start deploying the next-js app in Netlify at least for testing purposes
@fmvilas can you help I guess, I don't have access to Netlify

@Amzani Amzani mentioned this pull request Mar 13, 2024
2 tasks
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud

@Shurtu-gal
Copy link
Collaborator Author

@Shurtu-gal we should start deploying the next-js app in Netlify at least for testing purposes @fmvilas can you help I guess, I don't have access to Netlify

Agreed would be much better as some things might break over there if not reviewed properly.

Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shurtu-gal Shurtu-gal self-assigned this Mar 13, 2024
@Shurtu-gal
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit e84b96d into asyncapi:master Mar 13, 2024
19 checks passed
@Shurtu-gal Shurtu-gal deleted the feat/editor branch March 13, 2024 10:00
@Amzani Amzani mentioned this pull request Apr 22, 2024
4 tasks
@Shurtu-gal Shurtu-gal mentioned this pull request Apr 24, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Minimal studio App with a working editor and AsyncAPI documentation
3 participants