Fix Pytest fixture that changed DAG YAML file#256
Merged
Conversation
The test was modifying a fixture, and this fixture is not in .gitignore. The consequence is that if there were errors, the fixture was changed and developers would potentially commit an invalid fixture due to this. This PR leverages the previous change introduced in #236 to use envvars for templating YML filepaths
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 89.04% 89.04%
=======================================
Files 8 8
Lines 648 648
=======================================
Hits 577 577
Misses 71 71 ☔ View full report in Codecov by Sentry. |
pankajkoti
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pytest fixture modified a DAG YAML file, which is not in .gitignore.
The consequence is that if there were errors, the fixture was changed and developers would potentially commit an invalid fixture - that would be invalid in the CI.
This PR leverages the previous change introduced in #236 to use envvars for templating YML filepaths..