Support using envvar in config YAML#236
Merged
Merged
Conversation
pankajkoti
approved these changes
Oct 11, 2024
Contributor
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
Looks great, thanks for this great addition @tatiana :)
Merged
tatiana
added a commit
that referenced
this pull request
Oct 17, 2024
The test was modifying a fixture, and this fixture is not in .gitignore. The consequence is that if there were errors, the fixture was changed and developers would potentially commit an invalid fixture due to this. This PR leverages the previous change introduced in #236 to use envvars for templating YML filepaths
tatiana
added a commit
that referenced
this pull request
Oct 17, 2024
A Pytest fixture modified a DAG YAML file, which is not in .gitignore. The consequence is that if there were errors, the fixture was changed and developers would potentially commit an invalid fixture - that would be invalid in the CI. This PR leverages the previous change introduced in #236 to use envvars for templating YML filepaths..
tatiana
added a commit
that referenced
this pull request
Oct 22, 2024
### Added - Support using envvar in config YAML by @tatiana in #236 - **Callback improvements** - Support installed code via python callable string by @john-drews in #221 - Add `callback_file` & `callback_name` to `default_args` DAG level by @subbota19 in #218 - Cast callbacks to functions when set with `default_args` on TaskGroups by @baraldo and @pankajastro in #235 - **Telemetry** - For more information, please, read the [Privacy Notice](https://github.com/astronomer/dag-factory/blob/main/PRIVACY_NOTICE.md#collection-of-data). - Add scarf to readme for website analytics by @cmarteepants in #219 - Support telemetry during DAG parsing emitting data to Scarf by @tatiana in #250. ### Fixed - Build DAGs when tehre is an invalid YAML in the DAGs folder by @quydx and @tatiana in #184 ### Others - Development tools - Fix make docker-run by @pankajkoti in #249 - Add vim dot files to .gitignore by @tatiana in #228 - Use Hatchling to modern package building by @kaxil in #208 - CI - Fix static check failures in PR #218 by @pankajkoti in #251 - Fix pre-commit checks by @tatiana in #247 - Remove tox and corresponding build jobs in CI by @pankajkoti in #248 - Install Airflow with different versions in the CI by @pankajkoti in #237 - Run pre-commit hooks on all existing files by @pankajkoti in #245 - Add Python 3.11 and 3.12 to CI test pipeline by @pankajkoti in #229 - Tests - Fix duplicate test name by @pankajastro in #234 - Add static check by @pankajastro in #231 - Fix running tests locally (outside the CI) by @tatiana in #227 - Add the task_2 back to dataset example by @cmarteepants in #204 - Remove unnecessary config line by @jlaneve in #202 - Documentation - Update the license from MIT to Apache 2.0 by @pankajastro in #191 - Add registration icon and links to Airflow references by @cmarteepants in #190 - Update quickstart and add feature examples by @cmarteepants #189 ### Breaking changes - Removed support for Python 3.7 - The license was changed from MIT to Apache 2.0 Closes: #217
This was referenced Jun 21, 2025
pankajastro
pushed a commit
that referenced
this pull request
Jun 27, 2025
`expandvars` was initially added to `get_python_callable` to avoid the hard coded path for Py files #116. Then env var support is added to the entire YAML content #236. This makes `expandvars` no longer needed in the `get_python_callable` function, hence this PR removes it for better performance. Co-authored-by: Young Li <gyli@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for DAG Factory YAML configuration files to support referencing environment variables, such as
$SOME_PATH. Now DAG Factory resolves this during DAG parsing time.Motivation
Troubleshooting DAG Factory, for example, was difficult because DAGs had all hard-coded paths based on the
Dockerfile.The following commands failed to run because of the hard-coded paths:
Alternatives
Since DAG Factory expected absolute paths, using relative paths was not an option.
What changes
By setting the environment variable
CONFIG_ROOT_DIRto reference the root directory where DAG Factory example DAGs configs are, anyone should be able to run DAG Factory locally using theairflow dags testcommand: