Fix TypeError in Watcher mode with subprocess invocation#2227
Merged
pankajkoti merged 1 commit intoDec 26, 2025
Merged
Conversation
When using ExecutionMode.WATCHER with InvocationMode.SUBPROCESS, the _process_log_line_callable was being incorrectly bound as a method when accessed through an instance. This caused Python's descriptor protocol to pass 'self' as the first argument, resulting in: TypeError: _store_dbt_resource_status_from_log() takes 2 positional arguments but 3 were given The fix wraps the function with staticmethod() to prevent binding when accessed via self._process_log_line_callable. Also adds comprehensive tests for the _store_dbt_resource_status_from_log function and verifies the callable is not bound as a method.
✅ Deploy Preview for astronomer-cosmos canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeError that occurred when using ExecutionMode.WATCHER with InvocationMode.SUBPROCESS. The issue was caused by Python's descriptor protocol incorrectly binding _process_log_line_callable as a method when accessed through an instance, resulting in an extra self argument being passed.
Key changes:
- Wrapped
_process_log_line_callablewithstaticmethod()to prevent method binding - Added comprehensive test coverage for
_store_dbt_resource_status_from_logfunction - Added integration tests to verify the callable is not bound as a method
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cosmos/operators/watcher.py | Applied staticmethod() wrapper to _process_log_line_callable to prevent method binding |
| tests/operators/test_watcher.py | Added new test class TestStoreDbStatusFromLog with comprehensive unit and integration tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2227 +/- ##
==========================================
- Coverage 97.98% 97.98% -0.01%
==========================================
Files 95 95
Lines 6190 6189 -1
==========================================
- Hits 6065 6064 -1
Misses 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tatiana
approved these changes
Dec 26, 2025
Collaborator
tatiana
left a comment
tatiana
left a comment
There was a problem hiding this comment.
Thanks for fixing this, @pankajkoti ! Looks great
pankajkoti
deleted the
fix/watcher-subprocess-process-log-line-callback-binding
branch
pankajkoti
added a commit
that referenced
this pull request
Dec 29, 2025
When using ExecutionMode.WATCHER with InvocationMode.SUBPROCESS, the _process_log_line_callable was being incorrectly bound as a method when accessed through an instance. This caused Python's descriptor protocol to pass 'self' as the first argument, resulting in: TypeError: _store_dbt_resource_status_from_log() takes 2 positional arguments but 3 were given The fix wraps the function with staticmethod() to prevent binding when accessed via self._process_log_line_callable. Also adds comprehensive tests for the _store_dbt_resource_status_from_log function and verifies the callable is not bound as a method. closes: #2224
Merged
tatiana
added a commit
that referenced
this pull request
Jan 14, 2026
Bug Fixes * Fix ``DbtSourceWatcherOperator.template_fields`` to inherit from ``DbtSourceLocalOperator`` instead of ``DbtConsumerWatcherSensor`` by @pankajkoti in #2226 * Fix TypeError in Watcher mode with subprocess invocation by @pankajkoti in #2227 * Error when RenderConfig.invocation_mode is incorrectly set by @tatiana in #2267 Docs * Fix minor documentation typo by @dnskr in #2093 * Fix default values in documentation by @dnskr in #2092 * Remove emit event for ExecutionMode.AIRFLOW_ASYNC limitation in docs by @pankajastro in #2214 Others * Add test to check profile metrics with non-Cosmos operator by @pankajastro in #2215 * Fix CI main branch Airflow 2.6 tests by @tatiana in #2268 closes: astronomer/oss-integrations-private#295 Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using ExecutionMode.WATCHER with InvocationMode.SUBPROCESS, the _process_log_line_callable was being incorrectly bound as a method when accessed through an instance. This caused Python's descriptor protocol to pass 'self' as the first argument, resulting in:
TypeError: _store_dbt_resource_status_from_log() takes 2 positional arguments but 3 were given
The fix wraps the function with staticmethod() to prevent binding when accessed via self._process_log_line_callable.
Also adds comprehensive tests for the _store_dbt_resource_status_from_log function and verifies the callable is not bound as a method.
closes: #2224