Skip to content

Remove emit event for ExecutionMode.AIRFLOW_ASYNC limitation in docs#2214

Merged
pankajastro merged 3 commits into
mainfrom
remove_async_emit_event_limitation
Dec 19, 2025
Merged

Remove emit event for ExecutionMode.AIRFLOW_ASYNC limitation in docs#2214
pankajastro merged 3 commits into
mainfrom
remove_async_emit_event_limitation

Conversation

@pankajastro
Copy link
Copy Markdown
Contributor

@pankajastro pankajastro commented Dec 19, 2025

Related to: #2141

This PR updates the documentation to reflect that dataset emission is now supported in ExecutionMode.AIRFLOW_ASYNC since Cosmos 1.12.0. The limitation that prevented dataset events from being emitted in async mode has been resolved.

  • Removes the documented limitation about dataset events not being emitted in AIRFLOW_ASYNC mode
  • Updates documentation to include AIRFLOW_ASYNC in the list of execution modes supporting the emit_datasets feature

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 19, 2025

Deploy Preview for astronomer-cosmos ready!

Name Link
🔨 Latest commit 9af7d3a
🔍 Latest deploy log https://app.netlify.com/projects/astronomer-cosmos/deploys/6944eb479d6c0a0008d36f7e
😎 Deploy Preview https://deploy-preview-2214--astronomer-cosmos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pankajastro pankajastro marked this pull request as ready for review December 19, 2025 06:02
Copilot AI review requested due to automatic review settings December 19, 2025 06:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the documentation to reflect that dataset emission is now supported in ExecutionMode.AIRFLOW_ASYNC. The limitation that prevented dataset events from being emitted in async mode has been resolved.

  • Removes the documented limitation about dataset events not being emitted in AIRFLOW_ASYNC mode
  • Updates documentation to include AIRFLOW_ASYNC in the list of execution modes supporting the emit_datasets feature

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/getting_started/async-execution-mode.rst Removes limitation #10 stating that dataset events are not emitted in AIRFLOW_ASYNC mode
docs/configuration/scheduling.rst Adds ExecutionMode.AIRFLOW_ASYNC to the list of execution modes that support dataset emission
docs/configuration/render-config.rst Adds ExecutionMode.AIRFLOW_ASYNC to the list of execution modes that support the emit_datasets configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/configuration/scheduling.rst Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.97%. Comparing base (fd3d647) to head (9af7d3a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2214   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files          95       95           
  Lines        6187     6187           
=======================================
  Hits         6062     6062           
  Misses        125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pankajastro pankajastro merged commit 7dcfb1f into main Dec 19, 2025
88 checks passed
@pankajastro pankajastro deleted the remove_async_emit_event_limitation branch December 19, 2025 10:38
pankajkoti pushed a commit that referenced this pull request Dec 29, 2025
…2214)

Related to: #2141

This PR updates the documentation to reflect that dataset emission is
now supported in `ExecutionMode.AIRFLOW_ASYNC` since Cosmos 1.12.0. The
limitation that prevented dataset events from being emitted in async
mode has been resolved.

- Removes the documented limitation about dataset events not being
emitted in AIRFLOW_ASYNC mode
- Updates documentation to include AIRFLOW_ASYNC in the list of
execution modes supporting the `emit_datasets` feature
@pankajkoti pankajkoti mentioned this pull request Dec 29, 2025
tatiana added a commit that referenced this pull request Jan 14, 2026
Bug Fixes

* Fix ``DbtSourceWatcherOperator.template_fields`` to inherit from
``DbtSourceLocalOperator`` instead of ``DbtConsumerWatcherSensor`` by
@pankajkoti in #2226
* Fix TypeError in Watcher mode with subprocess invocation by
@pankajkoti in #2227
* Error when RenderConfig.invocation_mode is incorrectly set by @tatiana
in #2267

Docs

* Fix minor documentation typo by @dnskr in #2093
* Fix default values in documentation by @dnskr in #2092
* Remove emit event for ExecutionMode.AIRFLOW_ASYNC limitation in docs
by @pankajastro in #2214

Others

* Add test to check profile metrics with non-Cosmos operator by
@pankajastro in #2215
* Fix CI main branch Airflow 2.6 tests by @tatiana in #2268

closes:
astronomer/oss-integrations-private#295

Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
@tatiana tatiana added this to the Cosmos 1.12.1 milestone Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants