Remove emit event for ExecutionMode.AIRFLOW_ASYNC limitation in docs#2214
Conversation
✅ Deploy Preview for astronomer-cosmos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation to reflect that dataset emission is now supported in ExecutionMode.AIRFLOW_ASYNC. The limitation that prevented dataset events from being emitted in async mode has been resolved.
- Removes the documented limitation about dataset events not being emitted in AIRFLOW_ASYNC mode
- Updates documentation to include AIRFLOW_ASYNC in the list of execution modes supporting the
emit_datasetsfeature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/getting_started/async-execution-mode.rst | Removes limitation #10 stating that dataset events are not emitted in AIRFLOW_ASYNC mode |
| docs/configuration/scheduling.rst | Adds ExecutionMode.AIRFLOW_ASYNC to the list of execution modes that support dataset emission |
| docs/configuration/render-config.rst | Adds ExecutionMode.AIRFLOW_ASYNC to the list of execution modes that support the emit_datasets configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 95 95
Lines 6187 6187
=======================================
Hits 6062 6062
Misses 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…2214) Related to: #2141 This PR updates the documentation to reflect that dataset emission is now supported in `ExecutionMode.AIRFLOW_ASYNC` since Cosmos 1.12.0. The limitation that prevented dataset events from being emitted in async mode has been resolved. - Removes the documented limitation about dataset events not being emitted in AIRFLOW_ASYNC mode - Updates documentation to include AIRFLOW_ASYNC in the list of execution modes supporting the `emit_datasets` feature
Bug Fixes * Fix ``DbtSourceWatcherOperator.template_fields`` to inherit from ``DbtSourceLocalOperator`` instead of ``DbtConsumerWatcherSensor`` by @pankajkoti in #2226 * Fix TypeError in Watcher mode with subprocess invocation by @pankajkoti in #2227 * Error when RenderConfig.invocation_mode is incorrectly set by @tatiana in #2267 Docs * Fix minor documentation typo by @dnskr in #2093 * Fix default values in documentation by @dnskr in #2092 * Remove emit event for ExecutionMode.AIRFLOW_ASYNC limitation in docs by @pankajastro in #2214 Others * Add test to check profile metrics with non-Cosmos operator by @pankajastro in #2215 * Fix CI main branch Airflow 2.6 tests by @tatiana in #2268 closes: astronomer/oss-integrations-private#295 Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Related to: #2141
This PR updates the documentation to reflect that dataset emission is now supported in
ExecutionMode.AIRFLOW_ASYNCsince Cosmos 1.12.0. The limitation that prevented dataset events from being emitted in async mode has been resolved.emit_datasetsfeature