Fix `test_async_example_dag_without_setup_task` tests by pankajastro · Pull Request #1788 · astronomer/astronomer-cosmos

pankajastro · 2025-05-27T14:35:21Z

To avoid using setup and teardown task add env:

AIRFLOW__COSMOS__ENABLE_SETUP_ASYNC_TASK
AIRFLOW__COSMOS__ENABLE_TEARDOWN_ASYNC_TASK

CI: https://github.com/astronomer/astronomer-cosmos/actions/runs/15294655764/job/43020801285#step:7:698

netlify · 2025-05-27T14:35:26Z

✅ Deploy Preview for sunny-pastelito-5ecb04 ready!

Name	Link
🔨 Latest commit	`ab85303`
🔍 Latest deploy log	https://app.netlify.com/projects/sunny-pastelito-5ecb04/deploys/6836c6232cea090008a0413b
😎 Deploy Preview	https://deploy-preview-1788--sunny-pastelito-5ecb04.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

cloudflare-workers-and-pages · 2025-05-27T14:36:19Z

Deploying astronomer-cosmos with Cloudflare Pages

Latest commit:	`ab85303`
Status:	✅ Deploy successful!
Preview URL:	https://ccff5802.astronomer-cosmos.pages.dev
Branch Preview URL:	https://fix-async-test.astronomer-cosmos.pages.dev

View logs

codecov · 2025-05-28T08:35:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (c2f0a33) to head (ab85303).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
- Coverage   98.04%   98.02%   -0.02%     
==========================================
  Files          85       85              
  Lines        5256     5256              
==========================================
- Hits         5153     5152       -1     
- Misses        103      104       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

To avoid using setup and teardown task add env: - AIRFLOW__COSMOS__ENABLE_SETUP_ASYNC_TASK - AIRFLOW__COSMOS__ENABLE_TEARDOWN_ASYNC_TASK CI: https://github.com/astronomer/astronomer-cosmos/actions/runs/15294655764/job/43020801285#step:7:698 (cherry picked from commit bb73cb2)

@pankajkoti

**Bug Fixes** * Fix task instance ``try_number`` attribute for Airflow 3 compatibility by @pankajkoti in #1781 * Fix rendered template override logic when ``should_store_compiled_sql=False`` to restore pre-refactor behaviour by @pankajkoti in #1777 * Fix ``ProfileConfig`` in GCP Cloud Run job execution mode by @ramonvermeulen in #1783 * Fix dbt Docs page height by @1cadumagalhaes in #1793 * Add support to base64 encoded pem in Snowflake profiles by @brunocmartins in #1801 * Allow to disable owner inheritance from dbt into airflow DAG owners by @CorsettiS in #1787 * Fix Kubernetes Pod Operator conversion of ``container_resources`` to ``resources`` by @johnhoran in #1821 * Fix ``dbt deps`` with project level variables by @AlexandrKhabarov in #1822 * Fix source freshness warnings in kubernetes execution mode by @Pawel-Drabczyk in #1859 * Fix: Harden DbtNode against null config/meta by @pankajkoti in #1877 * Fix cache behaviour when DAG name contains "." by @tatiana in #1908 **Documentation** * Fix ``contributing.rst`` docs by @tatiana in #1785 * Fix docs rendering in Airflow 3 Compatibility by @pankajastro in #1790 * Fix typo in ``selecting-excluding.rst`` by @msshroff in #1814 * Update testing behavior file with ``ExecutionMode.KUBERNETES`` by @LuigiCerone in #1813 * Add step to fork repo in contributing guide by @pankajastro in #1808 * Fix ``depends_on`` attribute by @benedikt-buchert in #1837 * Fix character name by @ThePsyjo in #1860 * Update suggested MWAA startup script by @jaklan in #1884 * Make implementation & docs consistent regarding ``use_dataset_airflow3_uri_standard`` by @Anti0ff in #1878 **Others** * Set retries to 0 in example DAGs by @pankajkoti in #1782 * Fix ``test_async_example_dag_without_setup_task`` tests by @pankajastro in #1788 * Fix test hash value for Darwin when using Py 3.12.10 by @tatiana in #1786 * Upgrade Python and Airflow used to run MyPy checks by @tatiana in #1796 * Assert example DAGs' ``DagRunState`` and fix issues by @pankajkoti and @tatiana in #1778 * Update the conflict matrix to include AF 2.10, 2.11 & 3.0 and dbt 1.9 & 1.10 by @tatiana in #1820 * Fix broken CI due to Pydantic conflicts by @tatiana in #1809 * Drop Python 3.8 Support by @pankajastro in #1852 * Add Airflow 2.11 to the test matrix by @tatiana in #1807 * Require Authorize for all jobs on pull requests from external contributors in CI by @pankajkoti in #1861 * Leverage Trusted Publisher Management when publishing PyPI package by @tatiana in #1862 * CI: Add back accidentally deleted python-version matrix for running unit tests by @pankajkoti in #1872 * Remove commented code and fix mypy failures by @pankajkoti in #1876 * Add Zizmor analysis GitHub action by @pankajkoti in #1870 * Catch FlushError on Datasets for Airflow 2.11 dags test by @pankajkoti in #1880 * Add deprecation warning for ``LoadMode.CUSTOM`` parser by @duongphannamhung in #1885 * CI: Add GitHub CodeQL analysis workflow (codeql.yml) by @pankajkoti in #1871 * Resolve 'credential persistence through GitHub Actions artifacts' warnings from Zizmor by @pankajkoti in #1890 * Resolve 'overly broad permissions' warnings from Zizmor by @pankajkoti in #1889 * Resolve Zizmor error alerts for unpinned image references; mark alert for pull_request_target ignored by @pankajkoti in #1888 * Fix broken CI ``tests.py3.11-2.8-1.9:test-integration-setup`` by @tatiana in #1902 * Add dbt-core 1.10 to test matrix by @tatiana in #1767 * Pin package dbt-databricks by @pankajastro in #1909 * Enable matrix test entry for dbt-1.9, python-3.9 and airflow-3.0 tests in CI by @pankajastro in #1900 * Pre-commit updates: #1779, #1795, #1800, #1857, #1863, #1869, #1892, #1901 * Dependabot updates: #1904 Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>

@pankajkoti

**Bug Fixes** * Fix task instance ``try_number`` attribute for Airflow 3 compatibility by @pankajkoti in #1781 * Fix rendered template override logic when ``should_store_compiled_sql=False`` to restore pre-refactor behaviour by @pankajkoti in #1777 * Fix ``ProfileConfig`` in GCP Cloud Run job execution mode by @ramonvermeulen in #1783 * Fix dbt Docs page height by @1cadumagalhaes in #1793 * Add support to base64 encoded pem in Snowflake profiles by @brunocmartins in #1801 * Allow to disable owner inheritance from dbt into airflow DAG owners by @CorsettiS in #1787 * Fix Kubernetes Pod Operator conversion of ``container_resources`` to ``resources`` by @johnhoran in #1821 * Fix ``dbt deps`` with project level variables by @AlexandrKhabarov in #1822 * Fix source freshness warnings in kubernetes execution mode by @Pawel-Drabczyk in #1859 * Fix: Harden DbtNode against null config/meta by @pankajkoti in #1877 * Fix cache behaviour when DAG name contains "." by @tatiana in #1908 **Documentation** * Fix ``contributing.rst`` docs by @tatiana in #1785 * Fix docs rendering in Airflow 3 Compatibility by @pankajastro in #1790 * Fix typo in ``selecting-excluding.rst`` by @msshroff in #1814 * Update testing behavior file with ``ExecutionMode.KUBERNETES`` by @LuigiCerone in #1813 * Add step to fork repo in contributing guide by @pankajastro in #1808 * Fix ``depends_on`` attribute by @benedikt-buchert in #1837 * Fix character name by @ThePsyjo in #1860 * Update suggested MWAA startup script by @jaklan in #1884 * Make implementation & docs consistent regarding ``use_dataset_airflow3_uri_standard`` by @Anti0ff in #1878 **Others** * Set retries to 0 in example DAGs by @pankajkoti in #1782 * Fix ``test_async_example_dag_without_setup_task`` tests by @pankajastro in #1788 * Fix test hash value for Darwin when using Py 3.12.10 by @tatiana in #1786 * Upgrade Python and Airflow used to run MyPy checks by @tatiana in #1796 * Assert example DAGs' ``DagRunState`` and fix issues by @pankajkoti and @tatiana in #1778 * Update the conflict matrix to include AF 2.10, 2.11 & 3.0 and dbt 1.9 & 1.10 by @tatiana in #1820 * Fix broken CI due to Pydantic conflicts by @tatiana in #1809 * Drop Python 3.8 Support by @pankajastro in #1852 * Add Airflow 2.11 to the test matrix by @tatiana in #1807 * Require Authorize for all jobs on pull requests from external contributors in CI by @pankajkoti in #1861 * Leverage Trusted Publisher Management when publishing PyPI package by @tatiana in #1862 * CI: Add back accidentally deleted python-version matrix for running unit tests by @pankajkoti in #1872 * Remove commented code and fix mypy failures by @pankajkoti in #1876 * Add Zizmor analysis GitHub action by @pankajkoti in #1870 * Catch FlushError on Datasets for Airflow 2.11 dags test by @pankajkoti in #1880 * Add deprecation warning for ``LoadMode.CUSTOM`` parser by @duongphannamhung in #1885 * CI: Add GitHub CodeQL analysis workflow (codeql.yml) by @pankajkoti in #1871 * Resolve 'credential persistence through GitHub Actions artifacts' warnings from Zizmor by @pankajkoti in #1890 * Resolve 'overly broad permissions' warnings from Zizmor by @pankajkoti in #1889 * Resolve Zizmor error alerts for unpinned image references; mark alert for pull_request_target ignored by @pankajkoti in #1888 * Fix broken CI ``tests.py3.11-2.8-1.9:test-integration-setup`` by @tatiana in #1902 * Add dbt-core 1.10 to test matrix by @tatiana in #1767 * Pin package dbt-databricks by @pankajastro in #1909 * Enable matrix test entry for dbt-1.9, python-3.9 and airflow-3.0 tests in CI by @pankajastro in #1900 * Pre-commit updates: #1779, #1795, #1800, #1857, #1863, #1869, #1892, #1901 * Dependabot updates: #1904 Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>

pankajastro temporarily deployed to internal May 27, 2025 14:35 — with GitHub Actions Inactive

pankajastro temporarily deployed to internal May 27, 2025 14:52 — with GitHub Actions Inactive

pankajastro temporarily deployed to internal May 27, 2025 15:17 — with GitHub Actions Inactive

pankajastro temporarily deployed to internal May 27, 2025 15:37 — with GitHub Actions Inactive

pankajastro temporarily deployed to internal May 28, 2025 07:24 — with GitHub Actions Inactive

pre-commit-ci Bot temporarily deployed to internal May 28, 2025 07:26 Inactive

pankajastro force-pushed the fix_async_test branch from d9f95f6 to e316441 Compare May 28, 2025 07:52

pankajastro temporarily deployed to internal May 28, 2025 07:53 — with GitHub Actions Inactive

pre-commit-ci Bot temporarily deployed to internal May 28, 2025 07:54 Inactive

pankajastro commented May 28, 2025

View reviewed changes

Comment thread cosmos/operators/local.py Outdated

pankajastro temporarily deployed to internal May 28, 2025 08:12 — with GitHub Actions Inactive

pankajastro commented May 28, 2025

View reviewed changes

Comment thread cosmos/operators/_asynchronous/__init__.py Outdated

pankajastro commented May 28, 2025

View reviewed changes

Comment thread cosmos/operators/local.py Outdated

pankajastro temporarily deployed to internal May 28, 2025 08:13 — with GitHub Actions Inactive

pankajastro commented May 28, 2025

View reviewed changes

Comment thread tests/test_example_dags.py Outdated

pankajastro temporarily deployed to internal May 28, 2025 08:13 — with GitHub Actions Inactive

pankajastro changed the title ~~Fix async tests~~ Fix test_async_example_dag_without_setup_task tests May 28, 2025

pankajastro temporarily deployed to internal May 28, 2025 08:15 — with GitHub Actions Inactive

pankajastro and others added 10 commits May 28, 2025 13:45

Fix async tests

367461c

Use monkeypath

4714e64

Use monkeypath

51b1207

Use monkeypath

2ee655a

Use monkeypath

4bad384

Use monkeypath

6e6e270

🎨 [pre-commit.ci] Auto format from pre-commit.com hooks

d492021

Update cosmos/operators/local.py

afb2b82

Update cosmos/operators/_asynchronous/__init__.py

7b21d7d

Update cosmos/operators/local.py

265db01

pankajastro and others added 2 commits May 28, 2025 13:45

Update tests/test_example_dags.py

be27783

Use monkeypath

ab85303

pankajastro force-pushed the fix_async_test branch from 2aa1885 to ab85303 Compare May 28, 2025 08:15

pankajastro temporarily deployed to internal May 28, 2025 08:15 — with GitHub Actions Inactive

pankajastro marked this pull request as ready for review May 28, 2025 08:19

dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:testing Related to testing, like unit tests, integration tests, etc labels May 28, 2025

pankajkoti approved these changes May 28, 2025

View reviewed changes

pankajkoti merged commit bb73cb2 into main May 28, 2025
92 of 93 checks passed

pankajkoti deleted the fix_async_test branch May 28, 2025 08:41

pankajkoti added this to the Cosmos 1.10.2 milestone Jun 13, 2025

tatiana mentioned this pull request Aug 7, 2025

Release 1.10.2 #1911

Merged

pankajkoti mentioned this pull request Aug 8, 2025

Release 1.10.2 #1912

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `test_async_example_dag_without_setup_task` tests#1788

Fix `test_async_example_dag_without_setup_task` tests#1788
pankajkoti merged 12 commits into
mainfrom
fix_async_test

pankajastro commented May 27, 2025 •

edited

Loading

Uh oh!

netlify Bot commented May 27, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented May 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pankajastro commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for sunny-pastelito-5ecb04 ready!

Uh oh!

cloudflare-workers-and-pages Bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying astronomer-cosmos with Cloudflare Pages

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pankajastro commented May 27, 2025 •

edited

Loading

netlify Bot commented May 27, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented May 27, 2025 •

edited

Loading

codecov Bot commented May 28, 2025 •

edited

Loading