Fix RTIF override logic when should_store_compiled_sql=False to restore pre-refactor behaviour

[pankajkoti]

PR #1661 introduced a breaking change for standalone Cosmos operators when users set should_store_compiled_sql=False, as detailed in issue #1776.

The issue stems from a refactor in PR #1661. Previously, the RTIF refresh calls to the database were skipped because they occurred within the same function that checked the flag. After the refactor, these operations were moved to a separate _override_rtif function, but the should_store_compiled_sql condition was not checked there. As a result, the operator behaviour broke, as observed in the issue.

To restore the original behaviour, this change adds a condition in the override_rtif function to exit early when should_store_compiled_sql is False, ensuring consistency with the pre-refactor logic.

Closes: #1776

[netlify]

✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name	Link
🔨 Latest commit	2c5b6dd
🔍 Latest deploy log	https://app.netlify.com/projects/sunny-pastelito-5ecb04/deploys/68304cd6faf6960008ded733

[Copilot]

Pull Request Overview

This PR restores the original behavior by skipping RTIF overrides when should_store_compiled_sql=False, matching the pre-refactor logic.

• Added an early‐exit guard in _override_rtif to respect should_store_compiled_sql
• Introduced tests for Airflow 2 and Airflow 3 scenarios when storage is disabled

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
cosmos/operators/local.py	Added an early return in _override_rtif when storage flag is false
tests/operators/test_local.py	Added tests verifying no RTIF override for Airflow 2/3 if storage is disabled

Comments suppressed due to low confidence (1)

tests/operators/test_local.py:1943

• [nitpick] Consider patching operator._override_rtif_airflow_3_x and asserting it is not called, mirroring the Airflow 2 test to fully validate that no override is invoked when storage is disabled.

def test_override_rtif_airflow3_with_should_store_compiled_sql_false():

[cloudflare-workers-and-pages]

Deploying astronomer-cosmos with    Cloudflare Pages

Latest commit:	2c5b6dd
Status:	✅  Deploy successful!
Preview URL:	https://4905f7df.astronomer-cosmos.pages.dev
Branch Preview URL:	https://fix-pr-1661.astronomer-cosmos.pages.dev

View logs

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (62e9b40) to head (2c5b6dd).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1777   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          85       85           
  Lines        5247     5249    +2     
=======================================
+ Hits         5144     5146    +2     
  Misses        103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tatiana]

Excellent work at supporting the community and fixing this so quickly, @pankajkoti ! Did @tuantran0910 have a chance to confirm it solved the original issue?

[pankajkoti]

Did @tuantran0910 have a chance to confirm it solved the original issue?

Yes, @tuantran0910 confirmed that the fix worked for them in https://apache-airflow.slack.com/archives/C059CC42E9W/p1748014917886709?thread_ts=1747031958.683949&cid=C059CC42E9W