Skip to content

Try dropping Airflow dependency in mypy pre-commit #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pankajkoti wants to merge 3 commits into from
Closed

Try dropping Airflow dependency in mypy pre-commit #1691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3911145
Try dropping Airflow dependency in mypy pre-commit
pankajkoti Apr 23, 2025
53c8055
Use Airflow 2.10 for type-check job
pankajkoti Apr 23, 2025
53cdaaa
Run tests on current branch
pankajkoti Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: test

on:
push: # Run on pushes to the default branch
branches: [main]
branches: [main, drop-airflow-mypy-pre-commit]
pull_request_target: # Also run on pull requests originated from forks
branches: [main]

Expand Down Expand Up @@ -32,7 +32,7 @@ jobs:
architecture: "x64"

- run: pip3 install hatch
- run: hatch run tests.py3.9-2.8-1.9:type-check
- run: hatch run tests.py3.9-2.10-1.9:type-check

Run-Unit-Tests:
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ repos:
types-pytz,
types-requests,
types-python-dateutil,
apache-airflow,
]
files: ^cosmos
exclude: "dev/dags/dbt/simple/dbt_packages/.*"
Expand Down