Try dropping Airflow dependency in mypy pre-commit#1691
Closed
pankajkoti wants to merge 3 commits into
Closed
Conversation
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
Deploying astronomer-cosmos with
|
| Latest commit: |
53cdaaa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://edea93e2.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://drop-airflow-mypy-pre-commit.astronomer-cosmos.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 80 80
Lines 5024 5024
=======================================
Hits 4895 4895
Misses 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
appears mypy needs apache-airflow in the isolated environment it creates as otherwise it reports the errors as seen in the CI failures. Likely the fixes being made in #1687 is what we would need due to the nature of how mypy works with its isolated environments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.