fix(cli): ensure checkTx passes before waiting for inclusion#1636
Merged
quasystaty1 merged 1 commit intomainfrom Oct 9, 2024
Merged
fix(cli): ensure checkTx passes before waiting for inclusion#1636quasystaty1 merged 1 commit intomainfrom
quasystaty1 merged 1 commit intomainfrom
Conversation
sambukowski
approved these changes
Oct 4, 2024
SuperFluffy
changed the title
SuperFluffy
approved these changes
Oct 9, 2024
Contributor
SuperFluffy
left a comment
SuperFluffy
left a comment
There was a problem hiding this comment.
Change makes sense, thank you.
In the future we should provide flags to perform fire-and-forget submission or wait for inclusion.
steezeburger
added a commit
that referenced
this pull request
Oct 11, 2024
* main: feat(sequencer)!: enforce block ordering by transaction group (#1618) fix(cli): ensure checkTx passes before waiting for inclusion (#1636) chore(sequencer)!: update storage keys locations and values (ENG-898) (#1616) chore: cargo audit warning (#1644) chore(proto, core)!: remove action suffix from all action types (#1630) feat(sequencer)!: add limit to total amount of transactions in parked (#1638)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensuring checkTx passes before waiting for inclusion
Background
When using
submit_transaction_syncmethod, cli should exit oncheckTxerror code. Currently, cli first waits for inclusion which will never happen as the transaction failedcheckTxRelated Issues
Link any issues that are related, prefer full github links.
closes #1635