chore(proto, core)!: remove action suffix from all action types

[SuperFluffy]

Summary

This patch removes the *Action suffix from all protobuf on-wire and domain types that represent sequencer actions.

Background

The *Action suffix is redundant because at no point in the last 12 months was there a risk of confusing action types with non-action types that have a similar name (if there are any even).

Furthermore, we follow Rust naming conventions for types. Since we defined domain types in a module called action, clippy's module_name_repetition warning triggered on the names, requiring allow attributes to quiet the warnings and to stay in sync with the on-wire protobuf types.

Changes

• Remove the Action suffix from all action protobuf and domain types
• Rename transactions -> transaction in the former astria.protocol.transactions.v1alpha1
• Move all action protobuf types to a new file action.proto (similar to action.rs), but keeping the same astria.protocol.transaction.v1alpha1 protobuf package (because actions don't exist outside of transactions).
• Regenerate rust protobuf decoding/encoding code
• Rename enum FeeChange to enum FeeChangeKind because the former FeeChangeAction now clashes with the enum.

Testing

Only type names were changed. The code still compiles and all tests run. No business logic was changed.

Breaking Changelist

• This is not a network breaking change because domain type names (or protobuf names) do not manifest in business logic outside of tracing and logging.
• This is a breaking change for consumers of our protobuf API if they explicitly referred to action names.

Related Issues

Closes #1629

[joroshiba]

Protobuf changes LGTM

premature

[joroshiba]

I don't believe you need to import these since they are in the same package.

[SuperFluffy]

Unfortunately you do (assumed the same and tried without at first). Proof:

import "astria/primitive/v1/types.proto";
// import "astria/protocol/transaction/v1alpha1/actions.proto";
import "astria_vendored/penumbra/core/component/ibc/v1/ibc.proto";
import "astria_vendored/tendermint/abci/types.proto";
import "google/protobuf/any.proto";

proto/protocolapis/astria/protocol/transaction/v1alpha1/transaction.proto:25:12:field astria.protocol.transaction.v1alpha1.UnsignedTransaction.actions: unknown type Action

[SuperFluffy]

Squashed and rebased on top of recent main.

[joroshiba]

Approved with note on yet another potential fee related change as follow up.

[joroshiba]

Thinking on the semantics of the fee change given the need for the rust type change from this. Would it make more sense to have this message be something like:

enum FeeVariable {
  UNKNOWN_FEE_VARIABLE = 0;
  TRANSFER_BASE_FEE = 1;
  ...
}

message FeeChange {
  FeeVariable fee_variable = 1;
  astria.primitive.v1.Uint128 value = 2;
}

Then the rust fee variables could be related to the enum and the FeeChangeKind might be able to go away? Probably not for this PR though.

[SuperFluffy]

Discussed offline: generally agree. This action is not nice to read and its semantics are off. But will push that to a different PR.