fix(conductor): update for celestia-node v0.15.0#1367
Merged
ethanoroshiba merged 1 commit intomainfrom Aug 15, 2024
Merged
Conversation
SuperFluffy
previously requested changes
Aug 14, 2024
Contributor
SuperFluffy
left a comment
SuperFluffy
left a comment
There was a problem hiding this comment.
This checks if parsing failed and is extremely fragile.
Please try this branch instead: celestiaorg/lumina#340
joroshiba
requested changes
Aug 14, 2024
ethanoroshiba
force-pushed
the
eoroshiba/celestia_upgrade_fix_conductor
branch
from
24d24c8 to
cbae0c2
Compare
github-actions
bot
added
proto
ethanoroshiba
changed the base branch from
quasystaty1/chore/celestia-local-upgrade
to
main
ethanoroshiba
force-pushed
the
eoroshiba/celestia_upgrade_fix_conductor
branch
from
cbae0c2 to
24865b5
Compare
ethanoroshiba
removed
proto
ethanoroshiba
changed the title
joroshiba
approved these changes
Aug 15, 2024
joroshiba
dismissed
SuperFluffy’s stale review
discussed offline, important to get this in sooner than later. Can have better long term fix later.
steezeburger
added a commit
that referenced
this pull request
Aug 22, 2024
* main: refactor(core, proto)!: define app genesis state in proto (#1346) fix(sequencer): bump penumbra dep to fix ibc state access bug (#1389) feat(conductor)!: support disabled celestia auth (#1372) fix(sequencer)!: fix block fees (#1343) perf(sequencer): add benchmark for prepare_proposal (ENG-660) (#1337) fix(proto): fix import name mismatch (#1380) fix(ci): enable bridge withdrawer building with tag (#1374) feat(sequencer): rewrite memool to have per-account transaction storage and maintenance (#1323) refactor(core, sequencer)!: require that bridge unlock address always be set (#1339) fix(sequencer)!: take funds from bridge in ics20 withdrawals (#1344) fix(sequencer)!: fix TOCTOU issues by merging check and execution (#1332) fix: abci error code (#1280) refactor(core): shorten `try_from_block_info_and_data()` (#1371) fix(relayer): change `reqwest` for `isahc` in relayer blackbox tests (ENG-699) (#1366) fix(conductor): update for celestia-node v0.15.0 (#1367) Chore: Upgrade celestia-node to v0.14.1 (#1360) chore(charts): fix charts production templates (#1359) chore(core, proto): migrate byte slices from Vec to Bytes (#1319)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated
fetch_blobs_with_retry()to accept Celestia Node v0.15.0's newGetAll()return format. This will still work with Node v0.14.1 as well.Background
celestia-node v0.15.0 now returns an empty list of blobs for
GetAllif blobs are not found, which broke our currentjsonrpseeerror handling in conductor.Changes
fetch_blobs_with_retry()to accept theParseErrorthat Json RPC now throws when there are no blobs fetched.Testing
E2E tests working