fix(sequencer)!: take funds from bridge in ics20 withdrawals#1344
Merged
SuperFluffy merged 2 commits intomainfrom Aug 20, 2024
Merged
fix(sequencer)!: take funds from bridge in ics20 withdrawals#1344SuperFluffy merged 2 commits intomainfrom
SuperFluffy merged 2 commits intomainfrom
Conversation
SuperFluffy
changed the title
Fraser999
approved these changes
Aug 7, 2024
noot
reviewed
Aug 19, 2024
noot
approved these changes
Aug 19, 2024
…s signed by withdrawer
steezeburger
added a commit
that referenced
this pull request
Aug 22, 2024
* main: refactor(core, proto)!: define app genesis state in proto (#1346) fix(sequencer): bump penumbra dep to fix ibc state access bug (#1389) feat(conductor)!: support disabled celestia auth (#1372) fix(sequencer)!: fix block fees (#1343) perf(sequencer): add benchmark for prepare_proposal (ENG-660) (#1337) fix(proto): fix import name mismatch (#1380) fix(ci): enable bridge withdrawer building with tag (#1374) feat(sequencer): rewrite memool to have per-account transaction storage and maintenance (#1323) refactor(core, sequencer)!: require that bridge unlock address always be set (#1339) fix(sequencer)!: take funds from bridge in ics20 withdrawals (#1344) fix(sequencer)!: fix TOCTOU issues by merging check and execution (#1332) fix: abci error code (#1280) refactor(core): shorten `try_from_block_info_and_data()` (#1371) fix(relayer): change `reqwest` for `isahc` in relayer blackbox tests (ENG-699) (#1366) fix(conductor): update for celestia-node v0.15.0 (#1367) Chore: Upgrade celestia-node to v0.14.1 (#1360) chore(charts): fix charts production templates (#1359) chore(core, proto): migrate byte slices from Vec to Bytes (#1319)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ics20 withdrawals by actually taking funds from the provided bridge address.
Background
Prior to this change, funds were always taken from the signer of the
astria.protocol.v1alpha1.Ics20Withdrawalaction, even if itsbridge_addressfield was set.Changes
astria.protocol.v1alpha1.Ics20Withdrawal.bridge_addressto take funds in an ics20 withdrawal if set (and if it passes bridge checks)Testing
All present tests have been updated to check if the correct withdrawal target is found.
There should be tests for the entire
Ics20Withdrawal::check_and_executeflow. However, adding an ibc channel and port does not seem to be currently possible becausepenumbra_ibcdoes not export the channelStateWriteExttrait. This is left to a followup.Breaking Changelist
This is a breaking change because two different versions of sequencer will come to different conclusions on which account to take funds from.
Related Issues
Closes #1308