Skip to content

fix(bridge-withdrawer): skip linting generated contract code#1172

Merged
itamarreif merged 2 commits intomainfrom
itamarreif/bridge-withdrawer-lintgenerated
Jun 10, 2024
Merged

fix(bridge-withdrawer): skip linting generated contract code#1172
itamarreif merged 2 commits intomainfrom
itamarreif/bridge-withdrawer-lintgenerated

Conversation

@itamarreif
Copy link
Contributor

@itamarreif itamarreif commented Jun 10, 2024

Summary

fixes the linting of bridge contract bindings.

Background

the existing generated rust bindings for the bridge smart contracts do not comply with our linting standards.

Changes

  • add #[rustfmt::skip] to the generated bindings module in withdawer::ethereum
  • add the relinted generated files

Related Issues

Link any issues that are related, prefer full github links.

closes #1169

@itamarreif itamarreif marked this pull request as ready for review June 10, 2024 14:58
@itamarreif itamarreif requested a review from a team as a code owner June 10, 2024 14:58
@itamarreif itamarreif requested a review from Fraser999 June 10, 2024 14:58
@itamarreif itamarreif self-assigned this Jun 10, 2024
@itamarreif itamarreif added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 9cf79a7 Jun 10, 2024
@itamarreif itamarreif deleted the itamarreif/bridge-withdrawer-lintgenerated branch June 10, 2024 15:38
steezeburger added a commit that referenced this pull request Jun 10, 2024
* main:
  fix: ignore RUSTSEC-2021-0139 (#1171)
  chore(sequencer-relayer)!: remove functionality to restrict relaying blocks to only those proposed by a given validator (#1168)
  chore(metrics): update `metric_name` macro to handle a collection of names (#1163)
  fix(bridge-withdrawer): skip linting generated contract code (#1172)
  fix(core, sequencer): prefix removal source non-refund ics20 packet (#1162)
  chore(docs): add sequencer-relayer doc to specs (#1126)
  feat(bridge-withdrawer): sync logic (#1165)
  chore(withdrawer): replace contracts with `astria-bridge-contracts` submodule (#1164)
  feat(sequencer)!: implement bridge sudo and withdrawer addresses (#1142)
  feat(sequencer): implement refund to rollup logic upon ics20 transfer refund (#1161)
  feat(bridge-withdrawer): bridge withdrawer startup (#1160)
  feat(core, proto)!: add bech32m addresses (#1124)
  feat(withdrawer): bridged ERC20 token withdrawals (#1149)
  feat(sequencer-relayer)!: add chain IDs for sequencer and Celestia to config env vars (#1063)
  test(bridge-withdrawer): add submitter tests (#1133)
  chore: bump penumbra deps (#1159)
  feat(sequencer): implement `bridge/account_last_tx_hash` abci query (#1158)
  fix(withdrawer): use block subscription in batcher; send to destination_chain_address (#1157)
  fix(withdrawer): update AstriaWithdrawer to check that withdrawal value is sufficient (#1148)
  chore(ci): build bridge withdrawer images (#1156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't write generated outside of target/

3 participants