feat(sequencer-relayer)!: add chain IDs for sequencer and Celestia to config env vars#1063
Merged
feat(sequencer-relayer)!: add chain IDs for sequencer and Celestia to config env vars#1063
Conversation
github-actions
bot
added
sequencer-relayer
noot
reviewed
May 13, 2024
| { | ||
| trace!(?response); | ||
| } | ||
| response.map(|status_response| status_response.node_info.network.to_string()) |
Contributor
There was a problem hiding this comment.
the fact that this var is called network and not chain_id as in other rpc responses (such as genesis and block) bothers me a bit :p I think it's fine to leave though, as it should be the same as the chain id
Contributor
Author
There was a problem hiding this comment.
Yeah - it doesn't sit well with me either, but it's part of the tendermint API, so my hands are pretty much tied on this one I think.
noot
approved these changes
May 13, 2024
SuperFluffy
reviewed
May 16, 2024
crates/astria-sequencer-relayer/src/relayer/celestia_client/builder.rs
Outdated
Show resolved
Hide resolved
SuperFluffy
reviewed
May 16, 2024
SuperFluffy
reviewed
May 16, 2024
crates/astria-sequencer-relayer/tests/blackbox/helpers/test_sequencer_relayer.rs
Outdated
Show resolved
Hide resolved
SuperFluffy
reviewed
May 16, 2024
crates/astria-sequencer-relayer/tests/blackbox/helpers/test_sequencer_relayer.rs
Outdated
Show resolved
Hide resolved
SuperFluffy
approved these changes
May 16, 2024
Contributor
SuperFluffy
left a comment
SuperFluffy
left a comment
There was a problem hiding this comment.
Only minor comments. I tend to prefer received over actual nowadays because it requires less thinking. :)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
steezeburger
added a commit
that referenced
this pull request
Jun 10, 2024
* main: fix: ignore RUSTSEC-2021-0139 (#1171) chore(sequencer-relayer)!: remove functionality to restrict relaying blocks to only those proposed by a given validator (#1168) chore(metrics): update `metric_name` macro to handle a collection of names (#1163) fix(bridge-withdrawer): skip linting generated contract code (#1172) fix(core, sequencer): prefix removal source non-refund ics20 packet (#1162) chore(docs): add sequencer-relayer doc to specs (#1126) feat(bridge-withdrawer): sync logic (#1165) chore(withdrawer): replace contracts with `astria-bridge-contracts` submodule (#1164) feat(sequencer)!: implement bridge sudo and withdrawer addresses (#1142) feat(sequencer): implement refund to rollup logic upon ics20 transfer refund (#1161) feat(bridge-withdrawer): bridge withdrawer startup (#1160) feat(core, proto)!: add bech32m addresses (#1124) feat(withdrawer): bridged ERC20 token withdrawals (#1149) feat(sequencer-relayer)!: add chain IDs for sequencer and Celestia to config env vars (#1063) test(bridge-withdrawer): add submitter tests (#1133) chore: bump penumbra deps (#1159) feat(sequencer): implement `bridge/account_last_tx_hash` abci query (#1158) fix(withdrawer): use block subscription in batcher; send to destination_chain_address (#1157) fix(withdrawer): update AstriaWithdrawer to check that withdrawal value is sufficient (#1148) chore(ci): build bridge withdrawer images (#1156)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added two new configuration options specifying the expected chain IDs of the sequencer and Celestia networks.
Background
This is a guard rail to help avoid an operator accidentally connecting the relayer to the wrong network.
Changes
The configured values are used in the initialization phase, where the relevant clients query the appropriate servers for their chain IDs.
The Celestia client was already retrieving this info prior to this PR. Now it returns an error if the chain ID doesn't match, and this particular error variant causes the endless retry loop (and ultimately the process) to exit.
The sequencer client was not previously requesting this info, so it now does this in a somewhat similar manner to the Celestia client. Likewise, a chain ID mismatch there causes the process to exit.
Testing
A blackbox test for a mismatch in each of the chain IDs was added.
Breaking Changelist
ASTRIA_SEQUENCER_RELAYER_SEQUENCER_CHAIN_IDASTRIA_SEQUENCER_RELAYER_CELESTIA_CHAIN_IDRelated Issues
Part of #986.
Closes #978.