Only use relative paths in lockfile #6490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
internal
charliermarsh
force-pushed
the
charlie/relative-path
branch
2 times, most recently
from
13d078f
to
fa54e82
Compare
konstin
added
bug
konstin
force-pushed
the
charlie/relative-path
branch
from
a37bc3e
to
d03e036
Compare
konstin
changed the title
|
I think we have a problem whereby distribution / requirement |
|
I think we're too inconsistent about this unfortunately. Hmm... |
charliermarsh
force-pushed
the
charlie/relative-path
branch
2 times, most recently
from
07824d7
to
828a531
Compare
|
I suspect all the Windows tests will still fail? |
charliermarsh
force-pushed
the
charlie/relative-path
branch
from
828a531
to
bdb8f97
Compare
|
Trying to make this work but will later need to be broken up into multiple PRs. |
charliermarsh
force-pushed
the
charlie/relative-path
branch
from
bdb8f97
to
aa71ee9
Compare
charliermarsh
force-pushed
the
charlie/relative-path
branch
2 times, most recently
from
9877bf1
to
8d9f313
Compare
charliermarsh
force-pushed
the
charlie/canogs
branch
from
f93af4f
to
6ba30a3
Compare
charliermarsh
force-pushed
the
charlie/relative-path
branch
2 times, most recently
from
67442c5
to
bddebfb
Compare
charliermarsh
force-pushed
the
charlie/canogs
branch
from
bc6cd11
to
e6565c6
Compare
charliermarsh
force-pushed
the
charlie/relative-path
branch
from
bddebfb
to
844644b
Compare
charliermarsh
force-pushed
the
charlie/canogs
branch
from
e6565c6
to
a605a55
Compare
charliermarsh
force-pushed
the
charlie/relative-path
branch
from
844644b
to
acadf1f
Compare
charliermarsh
force-pushed
the
charlie/canogs
branch
from
a605a55
to
1bd96d7
Compare
In normalization, we need to convert from relative to absolute, not the other way round.
charliermarsh
force-pushed
the
charlie/relative-path
branch
from
acadf1f
to
84c114c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users who were using absolute paths in the
pyproject.tomlpreviously, this is a behavior change: We now convert all absolute paths inpathentries to relative paths. Since i assume that no-one relies on absolute path in their lockfiles - they are intended to be portable - I'm tagging this as a bugfix.Closes #6438
Fixes #6371