-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reframe use of --isolated
in tool run
#5470
Conversation
20d157d
to
e3f4522
Compare
bebf492
to
277d0d7
Compare
e3f4522
to
96c5781
Compare
277d0d7
to
0800ab1
Compare
96c5781
to
f96e87e
Compare
0800ab1
to
a1b888d
Compare
f96e87e
to
c0188ff
Compare
a1b888d
to
3c2add6
Compare
What's the idea behind "isolate" vs "isolated"? What tense do we want to use in our CLI? |
I suppose we could use |
Yeah I worry about using a different name than we would have just for the deprecation :/ it makes some sense pragmatically but I am also genuinely curious which tense we should use in general. |
It looks like we tend to use imperative: |
On the other hand, we have |
Although |
I think I feel the gist of what you're getting at. I think if we consider |
Yeah that's a good description. Ok, should we just reuse |
I think we would use it if not for the existing flag; and, since it's the same as before and mostly in preview, I think we should go for it. Sorry it adds complexity 😬 hopefully the deprecation is short-lived? I'm also okay with no-deprecation in the preview commands. |
c0188ff
to
bc43aae
Compare
I'm not 100% sure how to make it work since we'll now have |
Oh interesting, Clap lets commands override global arguments. Ok, that's easier... |
3c2add6
to
c849e0d
Compare
--isolated
in tool run
--isolated
in tool run
Summary
This PR gets rid of the global
--isolated
flag (which serves a bunch of independent responsibilities right now) onuv tool run
in favor of a dedicated--isolated
flag, which tells uv to avoid re-using an existing tool environment for this invocation. We'll add the same thing touv run
, to avoid using the base project environment.This will become a bit clearer in #5466, when we deprecate the
--isolated
flag on the preview APIs.