Deprecate the --isolated flag
#5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/deprecate-isolated
branch
from
c7eb248
to
36b2f4d
Compare
charliermarsh
changed the base branch from
charlie/no-project
to
charlie/isolate
|
Could you also update the |
|
Yes, thanks for the reminder. |
charliermarsh
force-pushed
the
charlie/deprecate-isolated
branch
from
36b2f4d
to
e3ccd31
Compare
charliermarsh
changed the base branch from
charlie/isolate
to
charlie/isolate-run
charliermarsh
commented
Jul 26, 2024
charliermarsh
commented
Jul 26, 2024
konstin
reviewed
Jul 26, 2024
konstin
approved these changes
Jul 26, 2024
charliermarsh
force-pushed
the
charlie/isolate-run
branch
2 times, most recently
from
e1412c5
to
1b4d926
Compare
charliermarsh
force-pushed
the
charlie/deprecate-isolated
branch
from
e3ccd31
to
5e77e2c
Compare
charliermarsh
force-pushed
the
charlie/isolate-run
branch
from
1b4d926
to
a9560ea
Compare
charliermarsh
force-pushed
the
charlie/deprecate-isolated
branch
from
5e77e2c
to
905aa85
Compare
charliermarsh
force-pushed
the
charlie/isolate-run
branch
2 times, most recently
from
383b43d
to
99638ad
Compare
charliermarsh
force-pushed
the
charlie/deprecate-isolated
branch
2 times, most recently
from
2bf70cc
to
abf2d17
Compare
charliermarsh
added a commit
that referenced
this pull request
Jul 30, 2024
## Summary This PR gets rid of the global `--isolated` flag (which serves a bunch of independent responsibilities right now) on `uv tool run` in favor of a dedicated `--isolated` flag, which tells uv to avoid re-using an existing tool environment for this invocation. We'll add the same thing to `uv run`, to avoid using the base project environment. This will become a bit clearer in #5466, when we deprecate the `--isolated` flag on the preview APIs.
charliermarsh
force-pushed
the
charlie/isolate-run
branch
from
99638ad
to
608a4cf
Compare
charliermarsh
force-pushed
the
charlie/deprecate-isolated
branch
2 times, most recently
from
73105e2
to
2879fde
Compare
|
Will review this next. |
|
Oh I was just gonna merge -- go for it, np. |
zanieb
reviewed
Jul 30, 2024
zanieb
reviewed
Jul 30, 2024
zanieb
approved these changes
Jul 30, 2024
charliermarsh
force-pushed
the
charlie/deprecate-isolated
branch
from
2879fde
to
ef16250
Compare
charliermarsh
force-pushed
the
charlie/deprecate-isolated
branch
from
ef16250
to
7b02c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR deprecates the
--isolatedflag. The treatment varies across the APIs:--no-config.tool runandrunspecifically, we don't even warn, because we can't differentiate the command-specific--isolatedfrom the global--isolated.