Use max rather than min to sort managed Pythons #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\cc @j178 |
zanieb
reviewed
Jul 19, 2024
Comment on lines
14
to
19
| pub enum ImplementationName { | ||
| GraalPy, | ||
| PyPy, | ||
| #[default] | ||
| CPython, | ||
| PyPy, | ||
| GraalPy, | ||
| } |
There was a problem hiding this comment.
This is pretty unintuitive, hope it doesn't bite us later :)
There was a problem hiding this comment.
I guess but it's also the standard derive implementation!
charliermarsh
added
internal
charliermarsh
force-pushed
the
charlie/ord
branch
from
eb0e39f
to
dbb6ac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See: #5139 and #5201 (comment).
Test Plan
Verified that 3.12 was chosen above 3.8 in:
cargo run -- python uninstall --allcargo run -- python install 3.8 3.12cargo run -- tool run -v httpx