Use max rather than min to sort managed Pythons

astral-sh · Jul 19, 2024 · dbb6ac2 · dbb6ac2
1 parent 93ba676
commit dbb6ac2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/crates/uv-python/src/implementation.rs b/crates/uv-python/src/implementation.rs
@@ -12,16 +12,16 @@ pub enum Error {
 
 #[derive(Debug, Eq, PartialEq, Clone, Copy, Default, PartialOrd, Ord, Hash)]
 pub enum ImplementationName {
+    GraalPy,
+    PyPy,
     #[default]
     CPython,
-    PyPy,
-    GraalPy,
 }
 
 #[derive(Debug, Eq, PartialEq, Clone, Ord, PartialOrd, Hash)]
 pub enum LenientImplementationName {
-    Known(ImplementationName),
     Unknown(String),
+    Known(ImplementationName),
 }
 
 impl ImplementationName {

diff --git a/crates/uv-python/src/managed.rs b/crates/uv-python/src/managed.rs
@@ -1,6 +1,7 @@
 use core::fmt;
 use fs_err as fs;
 use itertools::Itertools;
+use std::cmp::Reverse;
 use std::ffi::OsStr;
 use std::io::{self, Write};
 use std::path::{Path, PathBuf};
@@ -150,14 +151,14 @@ impl ManagedPythonInstallations {
                         },
                         Err(err) => Some(Err(err)),
                     })
-                    .collect::<Result<_, std::io::Error>>()
+                    .collect::<Result<_, io::Error>>()
                     .map_err(|err| Error::ReadError {
                         dir: self.root.clone(),
                         err,
                     })?;
                 directories
             }
-            Err(err) if err.kind() == std::io::ErrorKind::NotFound => vec![],
+            Err(err) if err.kind() == io::ErrorKind::NotFound => vec![],
             Err(err) => {
                 return Err(Error::ReadError {
                     dir: self.root.clone(),
@@ -174,7 +175,7 @@ impl ManagedPythonInstallations {
                     })
                     .ok()
             })
-            .sorted_unstable_by_key(|installation| installation.key().clone()))
+            .sorted_unstable_by_key(|installation| Reverse(installation.key().clone())))
     }
 
     /// Iterate over Python installations that support the current platform.