Always use release-only comparisons for requires-python
#4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/requires-python-upper-bound
branch
from
4cfb8a2
to
7c152c9
Compare
|
Gotta fix the snapshots, which is just about how we display those versions. |
charliermarsh
commented
Jul 4, 2024
| #[inline] | ||
| #[must_use] | ||
| pub fn only_release(&self) -> Self { | ||
| Self::new(self.release().iter().copied()) |
There was a problem hiding this comment.
Is it worth trying to avoid a copy here?
konstin
approved these changes
Jul 4, 2024
| @@ -148,3 +148,101 @@ impl TryFrom<&VersionSpecifier> for PubGrubSpecifier { | |||
| Ok(Self(ranges)) | |||
| } | |||
| } | |||
|
|
|||
| impl PubGrubSpecifier { | |||
There was a problem hiding this comment.
Can we merge the two impl PubGrubSpecifier blocks?
|
Sounds good. I'll add some more documentation. |
charliermarsh
force-pushed
the
charlie/requires-python-upper-bound
branch
2 times, most recently
from
ca57771
to
309d708
Compare
charliermarsh
force-pushed
the
charlie/requires-python-upper-bound
branch
from
309d708
to
416e17c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are a few ideas at play here:
Requires-Python, so we now do the same. That means, e.g., using3.13.0b0will be accepted by a project withRequires-Python: >= 3.13, which does not adhere to PEP 440 semantics but is somewhat intuitive.python_version >= '3.10' or python_version < '3.10'can be collapsed to the truthy marker.Closes #4714.
Closes #4272.
Closes #4719.