Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires-python normalization is unintuitive #4719

Closed
charliermarsh opened this issue Jul 2, 2024 · 4 comments · Fixed by #4794
Closed

requires-python normalization is unintuitive #4719

charliermarsh opened this issue Jul 2, 2024 · 4 comments · Fixed by #4794
Assignees
Labels
bug Something isn't working

Comments

@charliermarsh
Copy link
Member

E.g., python_version <= '3.9' or python_version > '3.9' doesn't simplify out, nor does python_version < '3.9' or python_version >= '3.9'.

Related to #4714.

@charliermarsh charliermarsh added the bug Something isn't working label Jul 2, 2024
@charliermarsh
Copy link
Member Author

If this were a Python package, it would actually be correct not to normalize these, due to pre-release handling and other details of PEP 440. But we generally want to ignore that stuff with requires-python.

@charliermarsh
Copy link
Member Author

I think this can be solved alongside #4714.

@ibraheemdev
Copy link
Member

Is this a duplicate of #4272?

@charliermarsh
Copy link
Member Author

@ibraheemdev - Yeah, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants