Allow configuring the toolchain fetch strategy #4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/toolchain-fetch-strategy
branch
2 times, most recently
from
43e6040
to
6d8ae94
Compare
zanieb
commented
Jun 27, 2024
zanieb
commented
Jun 27, 2024
|
I'm still not sure what our testing strategy is for toolchains since I don't want to fetch them in unit tests. I tested various combinations of |
konstin
approved these changes
Jun 28, 2024
BurntSushi
approved these changes
Jun 28, 2024
zanieb
force-pushed
the
zb/toolchain-fetch-strategy
branch
4 times, most recently
from
75e4ecf
to
6ceeeca
Compare
zanieb
force-pushed
the
zb/toolchain-fetch-strategy
branch
from
6ceeeca
to
5fed93b
Compare
zanieb
added a commit
that referenced
this pull request
Jul 2, 2024
I think `--toolchain-preference system` is sufficiently clear and `--toolchain-preference prefer-system` is excessively verbose. This was discussed in the original pull request at #4424 but because we had a case for preferring "installed managed" toolchains I was hesitant to change it. Now that I've dropped that in #4601, I think we can drop the prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
toolchain-fetchoption alongsidetoolchain-preferencewithautomatic(default) andmanualvalues allowing automatic toolchain fetches to be disabled (replaces #4425). Whenmanual, toolchains must be installed withuv toolchain install.Note this was previously implemented with
if-necessary,always,nevervariants but the interaction between this andtoolchain-preferencewas too confusing. By reducing to a binary option, things should be clearer. Theif-necessarybehavior moved totoolchain-preference=installed. See #4601 (comment) and #4601 (comment)