Add option to disable fetching managed toolchains #4425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/toolchain-setting
branch
from
19bc6c1
to
f2198cf
Compare
zanieb
force-pushed
the
zb/toolchain-only-installed
branch
from
8dfaf0a
to
29e49b5
Compare
zanieb
force-pushed
the
zb/toolchain-setting
branch
from
f2198cf
to
bd14d24
Compare
zanieb
force-pushed
the
zb/toolchain-only-installed
branch
from
29e49b5
to
013d493
Compare
zanieb
force-pushed
the
zb/toolchain-setting
branch
from
bd14d24
to
c64a2c8
Compare
zanieb
force-pushed
the
zb/toolchain-only-installed
branch
from
013d493
to
54aa755
Compare
zanieb
force-pushed
the
zb/toolchain-only-installed
branch
from
54aa755
to
6b028fd
Compare
zanieb
force-pushed
the
zb/toolchain-setting
branch
2 times, most recently
from
7963af4
to
a2e6b9c
Compare
zanieb
added a commit
that referenced
this pull request
Jul 2, 2024
Adds a `toolchain-fetch` option alongside `toolchain-preference` with `automatic` (default) and `manual` values allowing automatic toolchain fetches to be disabled (replaces #4425). When `manual`, toolchains must be installed with `uv toolchain install`. Note this was previously implemented with `if-necessary`, `always`, `never` variants but the interaction between this and `toolchain-preference` was too confusing. By reducing to a binary option, things should be clearer. The `if-necessary` behavior moved to `toolchain-preference=installed`. See #4601 (comment) and #4601 (comment)
|
Replaced by #4601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a toolchain preference (introduced in #4424) to only allow installed managed toolchains.
This might not actually belong in the toolchain preferences? i.e. the way it's currently spelled there's no option for "prefer system but allow installed managed toolchains". Enabling or disabling fetches could be totally independent of the toolchain preference. I'm on the fence on what the correct approach is. Regardless, this functionality is important and this is a good starting point for discussion on how to expose it.