Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve display of root package in range errors #3711

Merged
merged 2 commits into from
May 21, 2024
Merged

Improve display of root package in range errors #3711

merged 2 commits into from
May 21, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented May 21, 2024 •
edited
Loading

Instead of saying

we can conclude that you require==0a0.dev0 and pandas-stubs==2.0.3.230814 are incompatible.

we'll say

we can conclude that your requirements and pandas-stubs==2.0.3.230814 are incompatible.

Closes #3710

I'm not sure how to get unit test coverage for this, might look into that. Ideally we'd skip this branch entirely?

@zanieb zanieb added the error messages Messaging when something goes wrong label May 21, 2024
@zanieb zanieb requested a review from ibraheemdev May 21, 2024 18:02
@zanieb zanieb marked this pull request as ready for review May 21, 2024 18:02
ibraheemdev
ibraheemdev approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@ibraheemdev ibraheemdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Could we add a packse scenario for this?

@zanieb
Copy link
Member Author

zanieb commented May 21, 2024 •
edited
Loading

Last time I changed this in #1871 I also noted we had no test coverage.. hm

This message looks like an improvement for the case in #1855 though

@zanieb
Copy link
Member Author

zanieb commented May 21, 2024

I'm honestly not sure what the scenario is that prompts this. I'll try to think of one before merging.

@zanieb zanieb enabled auto-merge (squash) May 21, 2024 18:49
@zanieb zanieb mentioned this pull request May 21, 2024
Open
@zanieb
Copy link
Member Author

zanieb commented May 21, 2024

Tracking further improvements in #3716

@zanieb zanieb merged commit c14a7db into main May 21, 2024
44 checks passed
@zanieb zanieb deleted the zb/err-root-range branch May 21, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibraheemdev ibraheemdev ibraheemdev approved these changes

Assignees
No one assigned
Labels
error messages Messaging when something goes wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing resolution error message
2 participants
@zanieb @ibraheemdev