Avoid displaying "root" package when formatting terms #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/root-incompat
branch
from
b3cee7b
to
47a06dc
Compare
| fn fmt_package(package: &PubGrubPackage) -> String { | ||
| match package { | ||
| PubGrubPackage::Root(Some(name)) => name.to_string(), | ||
| PubGrubPackage::Root(None) => "you_require".to_string(), |
There was a problem hiding this comment.
Is the underscore here interntional?
There was a problem hiding this comment.
Nope dunno how that happened
zanieb
force-pushed
the
zb/root-incompat
branch
from
47a06dc
to
bc41275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have test coverage for this, but a term can reference an incompatibility with root and then we'll display the internal 'root' package to the user.
Raised in #1855