Use manylinux: auto for aarch64 builds #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure this will work. Let's try. |
messense
reviewed
May 9, 2024
Comment on lines
300
to
+305
| with: | ||
| target: ${{ matrix.platform.target }} | ||
| # On `aarch64`, use `manylinux: 2_28`; otherwise, use `manylinux: auto`. | ||
| manylinux: ${{ matrix.platform.arch == 'aarch64' && '2_28' || 'auto' }} | ||
| manylinux: auto |
There was a problem hiding this comment.
Try this workaround:
- uses: PyO3/maturin-aciton@v1
env:
# Workaround ring 0.17 build issue
CFLAGS_aarch64_unknown_linux_gnu: "-D__ARM_ARCH=8"
with:
manylinux: autoThere was a problem hiding this comment.
Wow I think that worked? Thanks! Are there any limitations here? Will the wheel work as expected?
There was a problem hiding this comment.
It should work as expected, I think the obvious limitation is that it might break in the future if ring/boringssl actually requires a newer GCC version.
charliermarsh
force-pushed
the
charlie/glibc
branch
from
2f2361b
to
92900b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #3439