Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panic for file url #3306

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Avoid panic for file url #3306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/cache-key/src/canonical_url.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ impl CanonicalUrl {
}

// Strip credentials.
url.set_password(None).unwrap();
url.set_username("").unwrap();
let _ = url.set_password(None);
let _ = url.set_username("");
Comment on lines -35 to +36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't we return on line 31 if there's no host? or line 26 if there cannot be a base? Weird.


// Strip a trailing slash.
if url.path().ends_with('/') {
Expand Down
Loading