Avoid panic for file url #3306
Merged
Avoid panic for file url #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using find links with a file url, we shouldn't panic because we can't remove username/password for a host-less url.
zanieb
reviewed
Apr 29, 2024
Comment on lines
-35
to
+36
| url.set_password(None).unwrap(); | ||
| url.set_username("").unwrap(); | ||
| let _ = url.set_password(None); | ||
| let _ = url.set_username(""); |
There was a problem hiding this comment.
Wouldn't we return on line 31 if there's no host? or line 26 if there cannot be a base? Weird.
zanieb
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using find links with a file url, we shouldn't panic because we can't remove username/password for a host-less url.
See #3262