Allow --project to refer to a pyproject.toml directly and reduce to a warning on other files#18513
Merged
zanieb merged 3 commits intoastral-sh:mainfrom Mar 16, 2026
Merged
Conversation
ffe47ad to
0eb8961
Compare
…-sh#18508) Fix a regression from astral-sh#17714 where `--project pyproject.toml` stopped working. When `--project` points to a `pyproject.toml` file, resolve to its parent directory since downstream code expects a directory. For other file types, emit a warning (or error with preview flag) and let downstream code fail naturally if there is no ancestor project. https://claude.ai/code/session_01NSUgyAxK5iz4VXKFW2L5ja
0eb8961 to
8e58133
Compare
zanieb
commented
Mar 16, 2026
These tests only need to run `python --version`, so the build-system section is unnecessary and adds network dependency on setuptools. https://claude.ai/code/session_01NSUgyAxK5iz4VXKFW2L5ja
charliermarsh
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18508
This unintentionally regressed in #17714 as it appeared that
--project <file>always failed but it actually succeeds if the file is has an ancestor directory with apyproject.toml.This also removes the warning for
--project [path/]pyproject.tomlas I think that's a fine use-case.