Warn if --project directory does not exist#17714
Merged
Conversation
konstin
added
the
enhancement
zanieb
reviewed
Jan 28, 2026
crates/uv/tests/it/run.rs
Outdated
|
|
||
| /// Using `--project` with a file path should warn (ignoring the eventual error). | ||
| #[test] | ||
| #[cfg(unix)] // TODO(konsti): Currently this doesn't error on Windows, but the result will vanish with the hard error |
Member
Author
There was a problem hiding this comment.
Currently, there's different behavior in this test on Unix and on Windows (I haven't investigated the Windows case, but this is bogus --project usage already). This difference will vanish when we upgrade the warning to an error, so I kept it as a TODO comment.
Member
There was a problem hiding this comment.
I think it's important to know why this doesn't fail on Windows per #17714 (comment)
zanieb
reviewed
Jan 28, 2026
crates/uv/tests/it/run.rs
Outdated
|
|
||
| ----- stderr ----- | ||
| warning: Project path `not-a-directory` is not a directory. This will become an error in the future. | ||
| error: failed to open file `[TEMP_DIR]/not-a-directory/uv.toml`: Not a directory (os error 20) |
Member
There was a problem hiding this comment.
Why do we attempt to open uv.toml there?
Member
Author
There was a problem hiding this comment.
I think we try to discover configuration in the project. TBH I don't don't see this error as a concern, but as additional motivation to now warn and eventually error with a proper message, instead of failing like this. As in, the test is surfacing something that's broken today, and this PR is part of solving this better. It's just that IMHO it isn't worth it to build an intermediate good solution here when we know that changing the warning to error is a good solution.
Member
There was a problem hiding this comment.
But doesn't that mean this is already an error today? in which case, why are we bothering with a warning?
Member
There was a problem hiding this comment.
Ah we fail because, as it says, it's "not a directory" so the system cannot traverse to attempt to read the child file. I think we should just fix the error message in this case on Linux and not warn?
Member
Author
There was a problem hiding this comment.
Good point, changed it to an error.
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
konstin
force-pushed
the
konsti/warn-project-dir-does-not-exist
branch
from
dbd4489 to
62571a2
Compare
zanieb
reviewed
Feb 4, 2026
zanieb
reviewed
Feb 4, 2026
konstin
force-pushed
the
konsti/warn-project-dir-does-not-exist
branch
2 times, most recently
from
72f2a14 to
75526f2
Compare
konstin
force-pushed
the
konsti/warn-project-dir-does-not-exist
branch
4 times, most recently
from
cc64262 to
641be9a
Compare
zanieb
reviewed
Mar 5, 2026
zanieb
reviewed
Mar 5, 2026
zanieb
reviewed
Mar 5, 2026
zanieb
approved these changes
Mar 5, 2026
konstin
force-pushed
the
konsti/warn-project-dir-does-not-exist
branch
from
e838cf7 to
d088cb0
Compare
zaniebot
pushed a commit
to zaniebot/uv
that referenced
this pull request
Mar 16, 2026
When `--project` points to a file (e.g., `pyproject.toml`), resolve to its parent directory with a deprecation warning instead of erroring. This restores the pre-0.10.10 behavior that was broken by astral-sh#17714. Closes astral-sh#18508 https://claude.ai/code/session_01NSUgyAxK5iz4VXKFW2L5ja
zaniebot
pushed a commit
to zaniebot/uv
that referenced
this pull request
Mar 16, 2026
When `--project` points to a file (e.g., `pyproject.toml`), resolve to its parent directory with a deprecation warning instead of erroring. PR astral-sh#17714 added a hard error for this case on the assumption that it was "already broken on Linux", but it actually worked accidentally: `Workspace::discover` walks `.ancestors()` from the given path, so passing `--project project/pyproject.toml` would walk up one level and find the `pyproject.toml` in the parent directory — the correct project root. This restores the pre-0.10.10 behavior while adding a deprecation warning to guide users toward passing a directory instead. Closes astral-sh#18508 https://claude.ai/code/session_01NSUgyAxK5iz4VXKFW2L5ja
zaniebot
pushed a commit
to zaniebot/uv
that referenced
this pull request
Mar 16, 2026
When `--project` points to a file, resolve to its parent directory. Passing `--project path/to/pyproject.toml` is explicitly allowed without warning. Other file types emit a deprecation warning. PR astral-sh#17714 added a hard error for file paths on the assumption that it "already errors on Linux", but it actually worked accidentally: `Workspace::discover` walks `.ancestors()` from the given path, so passing `--project project/pyproject.toml` would walk up one level and find the `pyproject.toml` in the parent directory — the correct project root. Closes astral-sh#18508 https://claude.ai/code/session_01NSUgyAxK5iz4VXKFW2L5ja
zaniebot
pushed a commit
to zaniebot/uv
that referenced
this pull request
Mar 16, 2026
Use the same `Project path ... is not a directory` phrasing and `project_path.user_display()` as the original PR astral-sh#17714 code. https://claude.ai/code/session_01NSUgyAxK5iz4VXKFW2L5ja
zaniebot
pushed a commit
to zaniebot/uv
that referenced
this pull request
Mar 16, 2026
…-sh#18508) Fix a regression from astral-sh#17714 where `--project pyproject.toml` stopped working. When `--project` points to a `pyproject.toml` file, resolve to its parent directory since downstream code expects a directory. For other file types, emit a warning (or error with preview flag) and let downstream code fail naturally if there is no ancestor project. https://claude.ai/code/session_01NSUgyAxK5iz4VXKFW2L5ja
zanieb
added a commit
that referenced
this pull request
Mar 16, 2026
…to a warning on other files (#18513) Closes #18508 This unintentionally regressed in #17714 as it appeared that `--project <file>` always failed but it actually succeeds if the file is has an ancestor directory with a `pyproject.toml`. This also removes the warning for `--project [path/]pyproject.toml` as I think that's a fine use-case. --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #17093
Errors if
--projectpoints to a file, as this already errors on Linux.