Skip to content

Skip installed Python check for URL dependencies#18211

Merged
charliermarsh merged 8 commits intoastral-sh:mainfrom
chiranjeevi-max:fix-marker-gated-requires-python
Mar 1, 2026
Merged

Skip installed Python check for URL dependencies#18211
charliermarsh merged 8 commits intoastral-sh:mainfrom
chiranjeevi-max:fix-marker-gated-requires-python

Conversation

@chiranjeevi-max
Copy link
Contributor

@chiranjeevi-max chiranjeevi-max commented Feb 27, 2026 •
edited by charliermarsh
Loading

Summary

Skip the installed Python version check when resolving URL dependencies. Such checks are already skipped for registry dependencies.

Closes #18199.

@chiranjeevi-max
Skip installed Python check for marker-gated path dependencies in forks
1dd15e9 
Closes astral-sh#18199

Signed-off-by: Chiranjeevi U <244287281+chiranjeevi-max@users.noreply.github.com>
@charliermarsh charliermarsh self-requested a review March 1, 2026 15:06
@charliermarsh charliermarsh self-assigned this Mar 1, 2026
@charliermarsh charliermarsh added the bug Something isn't working label Mar 1, 2026
@charliermarsh charliermarsh marked this pull request as draft March 1, 2026 19:46
@charliermarsh
Copy link
Member

charliermarsh commented Mar 1, 2026 •
edited
Loading

I pushed something a bit simpler. There's a lot of Chesterton's Fence here but... I think we can remove the check entirely?

We only care about the Python requirement matching our target version. There are two reasons we might care about the installed version matching the Python requirement:

  1. We need to run code to get the dependency metadata. But this code path happens after we retrieve the metadata (that's why we know the requires-python).
  2. We need to run code to install the package. But that's a concern for the install phase, not the resolve phase.

Also, AFAICT we already don't enforce this for source distributions that come from the registry...

@charliermarsh
Copy link
Member

charliermarsh commented Mar 1, 2026

(I'm fixing up the tests and adding a few more.)

@charliermarsh charliermarsh marked this pull request as ready for review March 1, 2026 20:05
@charliermarsh charliermarsh changed the title Skip installed Python check for marker-gated path dependencies in forks Skip installed Python check for URL dependencies Mar 1, 2026
@charliermarsh @claude
Remove unnecessary Result return from test function
edffd9f 
The `requires_python_source_dist_installed_incompatible_registry` test
never uses `?`, so clippy flagged the `Result<()>` return type as
`unnecessary_wraps`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@charliermarsh charliermarsh enabled auto-merge (squash) March 1, 2026 20:31
@charliermarsh charliermarsh merged commit 905d97d into astral-sh:main Mar 1, 2026
51 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Mar 3, 2026
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 11, 2026
build(deps): update uv to v0.10.9
a8a79c7 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [uv](https://github.com/astral-sh/uv) | patch | `0.10.7` → `0.10.9` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (uv)</summary>

### [`v0.10.9`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0109)

[Compare Source](astral-sh/uv@0.10.8...0.10.9)

Released on 2026-03-06.

##### Enhancements

- Add `fbgemm-gpu`, `fbgemm-gpu-genai`, `torchrec`, and `torchtune` to the PyTorch list ([#&#8203;18338](astral-sh/uv#18338))
- Add torchcodec to PyTorch List ([#&#8203;18336](astral-sh/uv#18336))
- Log the duration we took before erroring ([#&#8203;18231](astral-sh/uv#18231))
- Warn when using `uv_build` settings without `uv_build` ([#&#8203;15750](astral-sh/uv#15750))
- Add fallback to `/usr/lib/os-release` on Linux system lookup failure ([#&#8203;18349](astral-sh/uv#18349))
- Use `cargo auditable` to include SBOM in uv builds ([#&#8203;18276](astral-sh/uv#18276))

##### Configuration

- Add an environment variable for `UV_VENV_RELOCATABLE` ([#&#8203;18331](astral-sh/uv#18331))

##### Performance

- Avoid toml `Document` overhead ([#&#8203;18306](astral-sh/uv#18306))
- Use a single global workspace cache ([#&#8203;18307](astral-sh/uv#18307))

##### Bug fixes

- Continue on trampoline job assignment failures ([#&#8203;18291](astral-sh/uv#18291))
- Handle the hard link limit gracefully instead of failing ([#&#8203;17699](astral-sh/uv#17699))
- Respect build constraints for workspace members ([#&#8203;18350](astral-sh/uv#18350))
- Revalidate editables and other dependencies in scripts ([#&#8203;18328](astral-sh/uv#18328))
- Support Python 3.13+ on Android ([#&#8203;18301](astral-sh/uv#18301))
- Support `cp3-none-any` ([#&#8203;17064](astral-sh/uv#17064))
- Skip tool environments with broken links to Python on Windows ([#&#8203;17176](astral-sh/uv#17176))

##### Documentation

- Add documentation for common marker values ([#&#8203;18327](astral-sh/uv#18327))
- Improve documentation on virtual dependencies ([#&#8203;18346](astral-sh/uv#18346))

### [`v0.10.8`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0108)

[Compare Source](astral-sh/uv@0.10.7...0.10.8)

Released on 2026-03-03.

##### Python

- Add CPython 3.10.20
- Add CPython 3.11.15
- Add CPython 3.12.13

##### Enhancements

- Add Docker images based on Docker Hardened Images ([#&#8203;18247](astral-sh/uv#18247))
- Add resolver hint when `--exclude-newer` filters out all versions of a package ([#&#8203;18217](astral-sh/uv#18217))
- Configure a real retry minimum delay of 1s ([#&#8203;18201](astral-sh/uv#18201))
- Expand `uv_build` direct build compatibility ([#&#8203;17902](astral-sh/uv#17902))
- Fetch CPython from an Astral mirror by default ([#&#8203;18207](astral-sh/uv#18207))
- Download uv releases from an Astral mirror in installers by default ([#&#8203;18191](astral-sh/uv#18191))
- Add SBOM attestations to Docker images ([#&#8203;18252](astral-sh/uv#18252))
- Improve hint for installing meson-python when missing as build backend ([#&#8203;15826](astral-sh/uv#15826))

##### Configuration

- Add `UV_INIT_BARE` environment variable for `uv init` ([#&#8203;18210](astral-sh/uv#18210))

##### Bug fixes

- Prevent `uv tool upgrade` from installing excluded dependencies ([#&#8203;18022](astral-sh/uv#18022))
- Promote authentication policy when saving tool receipts ([#&#8203;18246](astral-sh/uv#18246))
- Respect exclusions in scripts ([#&#8203;18269](astral-sh/uv#18269))
- Retain default-branch Git SHAs in `pylock.toml` files ([#&#8203;18227](astral-sh/uv#18227))
- Skip installed Python check for URL dependencies ([#&#8203;18211](astral-sh/uv#18211))
- Respect constraints during `--upgrade` ([#&#8203;18226](astral-sh/uv#18226))
- Fix `uv tree` orphaned roots and premature deduplication ([#&#8203;17212](astral-sh/uv#17212))

##### Documentation

- Mention cooldown and tweak inline script metadata in dependency bots documentation ([#&#8203;18230](astral-sh/uv#18230))
- Move cache prune in GitLab to `after_script` ([#&#8203;18206](astral-sh/uv#18206))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My40OS4wIiwidXBkYXRlZEluVmVyIjoiNDMuNTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

@charliermarsh charliermarsh

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

uv lock --refresh crashes on local uv sources with mixed python versions

2 participants

@chiranjeevi-max @charliermarsh